ci: handle job cancellations properly

Use always() correctly.

Don't run notify_slack if job has been cancelled.

Author: sobomax

.github/workflows/.notify.yml

@@ -15,12 +15,13 @@ on:
 
 jobs:
   notify_slack:
+    if: ${{ inputs.job_result == 'failure' && github.repository == 'OpenSIPS/opensips' }}
     runs-on: ubuntu-latest
     env:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
     steps:
       - name: Notify slack fail
-        if: ${{ inputs.job_result == 'failure' && github.repository == 'OpenSIPS/opensips' && env.SLACK_BOT_TOKEN != '' }}
+        if: ${{ env.SLACK_BOT_TOKEN != '' }}
         uses: slackapi/slack-github-action@v3.0.3
         with:
           method: chat.postMessage
@@ -39,7 +40,6 @@ jobs:
                     text: "<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|Open this run in GitHub Actions>"
 
       - name: Post Fail
-        if: ${{ inputs.job_result == 'failure' }}
         run: |
           echo "💥 \"${{ inputs.job_name }}\" failed – marking workflow 💩" >&2
           exit 1

.github/workflows/cifuzz.yml

@@ -32,4 +32,4 @@ jobs:
       job_result: ${{ needs.Fuzzing.result }}
     secrets:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-    if: ${{ always() }}
+    if: ${{ always() && !cancelled() }}

.github/workflows/main.yml

@@ -86,4 +86,4 @@ jobs:
       job_result: ${{ needs.build.result }}
     secrets:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-    if: ${{ always() }}
+    if: ${{ always() && !cancelled() }}

.github/workflows/multiarch.yml

@@ -78,4 +78,4 @@ jobs:
       job_result: ${{ needs.build_multiarch.result }}
     secrets:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-    if: ${{ always() }}
+    if: ${{ always() && !cancelled() }}

.github/workflows/rtp.io.yml

@@ -139,4 +139,4 @@ jobs:
       job_result: ${{ needs.build_test_rtp_io_dock.result }}
     secrets:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-    if: ${{ always() }}
+    if: ${{ always() && !cancelled() }}

.github/workflows/unittests.yml

@@ -127,4 +127,4 @@ jobs:
       job_result: ${{ needs.build_and_test.result }}
     secrets:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-    if: ${{ always() }}
+    if: ${{ always() && !cancelled() }}