SDPAudioVideoMediaFormat WithUpdated methods should use current object not a format parameter (#1131)

* this makes much more sense as a method copying the current object
that is the approach already in use on SDPApplicationMediaFormat

providing a format parameter would only make sense if this was a static method, which it is not

* use updated method parameters

Author: SteveAyre

src/net/SDP/SDP.cs

@@ -450,7 +450,7 @@ public static SDP ParseSDPDescription(string sdpDescription)
                                             {
                                                 if (activeAnnouncement.MediaFormats.ContainsKey(id))
                                                 {
-                                                    activeAnnouncement.MediaFormats[id] = activeAnnouncement.MediaFormats[id].WithUpdatedRtpmap(rtpmap, activeAnnouncement.MediaFormats[id]);
+                                                    activeAnnouncement.MediaFormats[id] = activeAnnouncement.MediaFormats[id].WithUpdatedRtpmap(rtpmap);
                                                 }
                                                 else
                                                 {
@@ -514,7 +514,7 @@ public static SDP ParseSDPDescription(string sdpDescription)
                                             {
                                                 if (activeAnnouncement.MediaFormats.ContainsKey(id))
                                                 {
-                                                    activeAnnouncement.MediaFormats[id] = activeAnnouncement.MediaFormats[id].WithUpdatedFmtp(fmtp, activeAnnouncement.MediaFormats[id]);
+                                                    activeAnnouncement.MediaFormats[id] = activeAnnouncement.MediaFormats[id].WithUpdatedFmtp(fmtp);
                                                 }
                                                 else
                                                 {

src/net/SDP/SDPAudioVideoMediaFormat.cs

@@ -256,16 +256,15 @@ public string Name()
         /// equivalent type need to be adjusted by one party.
         /// </summary>
         /// <param name="id">The ID to set on the new format.</param>
-        /// <param name="format">The existing format to copy all properties except the ID from.</param>
         /// <returns>A new format.</returns>
-        public SDPAudioVideoMediaFormat WithUpdatedID(int id, SDPAudioVideoMediaFormat format) =>
-            new SDPAudioVideoMediaFormat(format.Kind, id, format.Rtpmap, format.Fmtp);
+        public SDPAudioVideoMediaFormat WithUpdatedID(int id) =>
+            new SDPAudioVideoMediaFormat(Kind, id, Rtpmap, Fmtp);
 
-        public SDPAudioVideoMediaFormat WithUpdatedRtpmap(string rtpmap, SDPAudioVideoMediaFormat format) =>
-            new SDPAudioVideoMediaFormat(format.Kind, format.ID, rtpmap, format.Fmtp);
+        public SDPAudioVideoMediaFormat WithUpdatedRtpmap(string rtpmap) =>
+            new SDPAudioVideoMediaFormat(Kind, ID, rtpmap, Fmtp);
 
-        public SDPAudioVideoMediaFormat WithUpdatedFmtp(string fmtp, SDPAudioVideoMediaFormat format) =>
-            new SDPAudioVideoMediaFormat(format.Kind, format.ID, format.Rtpmap, fmtp);
+        public SDPAudioVideoMediaFormat WithUpdatedFmtp(string fmtp) =>
+            new SDPAudioVideoMediaFormat(Kind, ID, Rtpmap, fmtp);
 
         /// <summary>
         /// Maps an audio SDP media type to a media abstraction layer audio format.