Skip to content

Commit a68546d

Browse files
committed
Fixed broken links.
1 parent ed9a387 commit a68546d

File tree

4 files changed

+17
-7
lines changed

4 files changed

+17
-7
lines changed

README.md

+10-2
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ Test run at 2024-12-21 22:16:22.531491
6161

6262
If you are interested in adding a library to this project the recommended steps are listed below. The steps don't necessarily have to be completed in any specific order.
6363

64-
- Write a Peer Connection Test Client application according to the [specification](doc/EchoTestSpecification.md#client-peer-operation) or base it off an [existing application](doc/EchoTestSpecification.md#view-the-code).
64+
- Write a Peer Connection Test Client application according to the [specification](doc/PeerConnectionTestSpecification.md#client-peer-operation) or base it off an [existing application](doc/PeerConnectionTestSpecification.md#view-the-code).
6565

66-
- Test your client by building and running one of the [Peer Connection Test Servers](https://github.com/sipsorcery/webrtc-echoes/blob/master/doc/EchoTestSpecification.md#view-the-code) or you can use one of the [Peer Connection Test Server Docker Images](https://github.com/sipsorcery?tab=packages&q=webrtc):
66+
- Test your client by building and running one of the [Peer Connection Test Servers](doc/PeerConnectionTestSpecification.md#view-the-code) or you can use one of the [Peer Connection Test Server Docker Images](https://github.com/sipsorcery?tab=packages&q=webrtc):
6767

6868
````
6969
docker run -it --rm --init -p 8080:8080 ghcr.io/sipsorcery/aiortc-webrtc-echo
@@ -82,4 +82,12 @@ docker run -it --rm --init -p 8080:8080 ghcr.io/sipsorcery/werift-webrtc-echo
8282

8383
- Repeat the process for a [Peer Connection Test Server](doc/PeerConnectionTestSpecification.md#server-peer-operation).
8484

85+
- Servers can also be tested with docker images:
86+
87+
````
88+
docker run --entrypoint "/client.sh" ghcr.io/sipsorcery/pion-webrtc-echo http://host.docker.internal:8080/offer
89+
docker run --entrypoint "/client.sh" ghcr.io/sipsorcery/sipsorcery-webrtc-echo http://host.docker.internal:8080/offer
90+
etc...
91+
````
92+
8593
- Create a [Dockerfile](doc/EchoTestDockerRequirements.md) and add a Pull Request for it so your Peer Connection Test application(s) can be included in the automated testing.

libwebrtc/PcFactory.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ PcFactory::PcFactory() :
6565
_pcf_deps.event_log_factory = std::make_unique<webrtc::RtcEventLogFactory>(_pcf_deps.task_queue_factory.get());
6666
_pcf_deps.audio_encoder_factory = webrtc::CreateBuiltinAudioEncoderFactory();
6767
_pcf_deps.audio_decoder_factory = webrtc::CreateBuiltinAudioDecoderFactory();
68+
//_pcf_deps.video_encoder_factory = webrtc::CreateBuiltinVideoEncoderFactory(); // Missing symbol in m132 build (tried everything).
69+
//_pcf_deps.video_decoder_factory = webrtc::CreateBuiltinVideoDecoderFactory(); // Missing symbol in m132 build (tried everything).
6870
_pcf_deps.adm = rtc::scoped_refptr<webrtc::AudioDeviceModule>(FakeAudioCaptureModule::Create());
6971
_pcf_deps.audio_processing = apm; // Gets moved in EnableMedia.
7072

libwebrtc/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ src$ gclient sync --force
116116
And then:
117117

118118
````
119-
src$ gn gen out/Default --args="is_component_build=false use_custom_libcxx=false use_custom_libcxx_for_host=false rtc_enable_protobuf=false"
119+
src$ gn gen out/Default --args="use_custom_libcxx=false"
120120
src$ gn args out/Default --list --short --overrides-only
121121
src$ ninja -C out/Default
122122
src$ out/Default/webrtc_lib_link_test

sipsorcery/server/Program.cs

100644100755
+4-4
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,8 @@ public WebRTCEchoServer(List<IPAddress> presetAddresses)
191191

192192
public async Task<RTCPeerConnection> GotOffer(RTCSessionDescriptionInit offer)
193193
{
194-
logger.LogTrace($"SDP offer received.");
195-
logger.LogTrace(offer.sdp);
194+
logger.LogDebug($"SDP offer received.");
195+
logger.LogDebug(offer.sdp);
196196

197197
var pc = new RTCPeerConnection();
198198

@@ -253,8 +253,8 @@ public async Task<RTCPeerConnection> GotOffer(RTCSessionDescriptionInit offer)
253253
var answer = pc.createAnswer();
254254
await pc.setLocalDescription(answer);
255255

256-
logger.LogTrace($"SDP answer created.");
257-
logger.LogTrace(answer.sdp);
256+
logger.LogDebug($"SDP answer created.");
257+
logger.LogDebug(answer.sdp);
258258

259259
return pc;
260260
}

0 commit comments

Comments
 (0)