Skip to content

Commit b781b12

Browse files
committed
Skeptical.
1 parent a20b530 commit b781b12

File tree

1 file changed

+24
-16
lines changed

1 file changed

+24
-16
lines changed

.github/workflows/datachannel_echo-test.yml

+24-16
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,18 @@ jobs:
1717
# Job Description: Performs the Data Channel Test between each combination of the client and server for each library.
1818
interop-tests:
1919
runs-on: ubuntu-latest
20-
# See https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#using-job-outputs-in-a-matrix-job
21-
outputs:
22-
results: ${{ steps.set_output.outputs.result }} # Capture all results in one output
23-
24-
strategy:
25-
matrix:
26-
server: ["libdatachannel", "sipsorcery", "werift"]
27-
client: ["libdatachannel", "sipsorcery", "werift"]
20+
2821
services:
22+
redis:
23+
image: redis:alpine
24+
ports:
25+
- 6379:6379
26+
options: >-
27+
--health-cmd "redis-cli ping"
28+
--health-interval 10s
29+
--health-timeout 5s
30+
--health-retries 5
31+
2932
echo-test-server:
3033
image: ghcr.io/sipsorcery/${{ matrix.server }}-webrtc-echo
3134
credentials:
@@ -35,8 +38,19 @@ jobs:
3538
# - 8080:8080
3639
options: "--name echo-server"
3740

41+
strategy:
42+
matrix:
43+
server: ["libdatachannel", "sipsorcery", "werift"]
44+
client: ["libdatachannel", "sipsorcery", "werift"]
45+
3846
steps:
3947

48+
- name: Wait for Redis to be ready
49+
run: |
50+
for i in {1..30}; do
51+
redis-cli -h 127.0.0.1 ping && break || sleep 1;
52+
done
53+
4054
- name: Data Channel test for server ${{ matrix.server }} and ${{ matrix.client }} client
4155
id: check_connection
4256
run: |
@@ -49,14 +63,8 @@ jobs:
4963
- name: Set output results
5064
id: set_output
5165
run: |
52-
# Create a string for the result entry
53-
result_entry="${{ matrix.server }},${{ matrix.client }},${{ steps.check_connection.outputs.TEST_RESULT }}"
54-
55-
# Append the result entry to the output variable
56-
echo "RESULTS+=($result_entry)" >> $GITHUB_ENV # Use environment variable for results
57-
58-
# Also set the results for output
59-
echo "results=${{ env.RESULTS }}" >> $GITHUB_OUTPUT
66+
# Store this in Redis!
67+
#result_entry="${{ matrix.server }},${{ matrix.client }},${{ steps.check_connection.outputs.TEST_RESULT }}"
6068
6169
# Job Description: Collates the results of the interop tests into a mark down table.
6270
collate:

0 commit comments

Comments
 (0)