Make sure cache is not used before it is ready

sirbrillig · sirbrillig · commit 10e2dc005f78 · 2025-03-16T18:59:26.000-04:00
diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php
@@ -158,7 +158,7 @@ class VariableAnalysisSniff implements Sniff
 	 *
 	 * @var array<array<int|string>>
 	 */
-	private $passByRefFunctionsCache = [];
+	private $passByRefFunctionsCache;
 
 	public function __construct()
 	{
@@ -211,7 +211,7 @@ private function getPassByReferenceFunction($functionName)
 	 */
 	private function getPassByReferenceFunctions()
 	{
-		if ($this->passByRefFunctionsCache) {
+		if (isset($this->passByRefFunctionsCache)) {
 			return $this->passByRefFunctionsCache;
 		}
 		$passByRefFunctions = Constants::getPassByReferenceFunctions();

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ class VariableAnalysisSniff implements Sniff`
`158`	`158`	`*`
`159`	`159`	`* @var array<array<int\|string>>`
`160`	`160`	`*/`
`161`		`- private $passByRefFunctionsCache = [];`
	`161`	`+ private $passByRefFunctionsCache;`
`162`	`162`
`163`	`163`	`public function __construct()`
`164`	`164`	`{`
`@@ -211,7 +211,7 @@ private function getPassByReferenceFunction($functionName)`
`211`	`211`	`*/`
`212`	`212`	`private function getPassByReferenceFunctions()`
`213`	`213`	`{`
`214`		`- if ($this->passByRefFunctionsCache) {`
	`214`	`+ if (isset($this->passByRefFunctionsCache)) {`
`215`	`215`	`return $this->passByRefFunctionsCache;`
`216`	`216`	`}`
`217`	`217`	`$passByRefFunctions = Constants::getPassByReferenceFunctions();`