Skip to content

Commit 5e2f18e

Browse files
authored
GH Actions: use the xmllint-validate action runner (#350)
Instead of doing all the installation steps for xmllint validation in the workflow, use the ✨ new dedicated `phpcsstandards/xmllint-validate` action runner instead. Ref: https://github.com/marketplace/actions/xmllint-validate Co-authored-by: jrfnl <[email protected]>
1 parent ffb6f16 commit 5e2f18e

File tree

1 file changed

+5
-17
lines changed

1 file changed

+5
-17
lines changed

.github/workflows/csqa.yml

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -47,27 +47,15 @@ jobs:
4747
# Bust the cache at least once a month - output format: YYYY-MM.
4848
custom-cache-suffix: $(date -u "+%Y-%m")
4949

50-
# Updating the lists can fail intermittently, typically after Microsoft has released a new package.
51-
# This should not be blocking for this job, so ignore any errors from this step.
52-
# Ref: https://github.com/dotnet/core/issues/4167
53-
- name: Update the available packages list
54-
continue-on-error: true
55-
run: sudo apt-get update
56-
57-
- name: Install xmllint
58-
run: sudo apt-get install --no-install-recommends -y libxml2-utils
59-
60-
# Show XML violations inline in the file diff.
61-
# @link https://github.com/marketplace/actions/xmllint-problem-matcher
62-
- name: Enable showing XML issues inline
63-
uses: korelstar/xmllint-problem-matcher@v1
64-
6550
# Validate the XML file.
66-
# @link http://xmlsoft.org/xmllint.html
6751
- name: Validate ruleset against schema
68-
run: xmllint --noout --schema vendor/squizlabs/php_codesniffer/phpcs.xsd VariableAnalysis/ruleset.xml
52+
uses: phpcsstandards/xmllint-validate@v1
53+
with:
54+
pattern: "VariableAnalysis/ruleset.xml"
55+
xsd-file: "vendor/squizlabs/php_codesniffer/phpcs.xsd"
6956

7057
# Check the code-style consistency of the XML file.
58+
# Note: this needs xmllint, but that will be installed via the phpcsstandards/xmllint-validate action runner in the previous step.
7159
- name: Check XML code style
7260
run: diff -B ./VariableAnalysis/ruleset.xml <(xmllint --format "./VariableAnalysis/ruleset.xml")
7361

0 commit comments

Comments
 (0)