Move test directory out of package path (#168)

* Move tests directory to top level

* Modify tests directory path in other files

* Move fixtures back adjacent to tests

* Exclude vendor from phpcs

* Tests: fix composer autoload

1. Make the namespace of the `VariableAnalysisTest` file reflect the path the file.
2. Add an `autoload-dev` section to the `composer.json`
    * The unit tests are not shipped in the distribution package, so they are only available in a `dev` environment, which is exactly what `autoload-dev` is targetting.
    * Setting the `tests` directory as a secondary path for PSR4 autoload should fix compatibility with Composer 2.

* Rename tests/Sniffs to tests/VariableAnalysisSniff

* Rename tests to Tests

* Rename Tests directory paths in files

* Rename test namespace to match new path

* Update .gitattributes from tests to Tests

Co-Authored-By: Juliette <[email protected]>

Co-authored-by: jrfnl <[email protected]>
Co-authored-by: Juliette <[email protected]>

Author: sirbrillig

.gitattributes

@@ -13,7 +13,7 @@
 /phpunit.xml.dist export-ignore
 /phpunit.circleci.xml export-ignore
 /.circleci/ export-ignore
-/VariableAnalysis/Tests/ export-ignore
+/Tests/ export-ignore
 
 #
 # Auto detect text files and perform LF normalization

VariableAnalysis/Tests/BaseTestCase.php renamed to Tests/BaseTestCase.php

@@ -8,7 +8,7 @@
 
 class BaseTestCase extends TestCase {
   const STANDARD_NAME = 'VariableAnalysis';
-  const SNIFF_FILE = __DIR__ . '/../Sniffs/CodeAnalysis/VariableAnalysisSniff.php';
+  const SNIFF_FILE = __DIR__ . '/../VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php';
 
   public function prepareLocalFileForSniffs($fixtureFile) {
     $config            = new Config();
@@ -41,6 +41,6 @@ public function getErrorLineNumbersFromFile(LocalFile $phpcsFile) {
   }
 
   public function getFixture($fixtureFilename) {
-    return realpath(__DIR__ . '/CodeAnalysis/fixtures/' . $fixtureFilename);
+    return realpath(__DIR__ . '/VariableAnalysisSniff/fixtures/' . $fixtureFilename);
   }
 }

VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php renamed to Tests/VariableAnalysisSniff/VariableAnalysisTest.php

@@ -1,5 +1,5 @@
 <?php
-namespace VariableAnalysis\Tests\CodeAnalysis;
+namespace VariableAnalysis\Tests\VariableAnalysisSniff;
 
 use VariableAnalysis\Tests\BaseTestCase;
 

VariableAnalysis/Tests/CodeAnalysis/fixtures/AnonymousClassFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/AnonymousClassFixture.php

@@ -0,0 +1,3 @@
+<?php
+require_once(__DIR__ . '/../vendor/squizlabs/php_codesniffer/tests/bootstrap.php');
+require_once(__DIR__ . '/BaseTestCase.php');

VariableAnalysis/Tests/CodeAnalysis/fixtures/AnonymousClassWithPropertiesFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/AnonymousClassWithPropertiesFixture.php

@@ -26,6 +26,11 @@
             "VariableAnalysis\\": "VariableAnalysis/"
         }
     },
+    "autoload-dev": {
+        "psr-4": {
+            "VariableAnalysis\\Tests\\": "Tests/"
+        }
+    },
     "minimum-stability": "dev",
     "prefer-stable": true,
     "scripts": {

VariableAnalysis/Tests/CodeAnalysis/fixtures/AssignmentByReferenceFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/AssignmentByReferenceFixture.php

@@ -26,6 +26,11 @@
             "VariableAnalysis\\": "VariableAnalysis/"
         }
     },
+    "autoload-dev": {
+        "psr-4": {
+            "VariableAnalysis\\Tests\\": "Tests/"
+        }
+    },
     "minimum-stability": "dev",
     "prefer-stable": true,
     "scripts": {

VariableAnalysis/Tests/CodeAnalysis/fixtures/ClassReferenceFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/ClassReferenceFixture.php

@@ -1,14 +1,9 @@
 <?xml version="1.0"?>
 <ruleset name="PaytonsStandard">
-    <description>
-        Originally from https://gist.github.com/Ovsyanka/e2ab2ff76e7c0d7e75a1e4213a03ff95
-        PSR2 with changes:
-            - bracers on end of line instead new line
-            - two space indentation
-    </description>
-
     <file>./VariableAnalysis/</file>
-    <exclude-pattern>./VariableAnalysis/Tests/CodeAnalysis/fixtures/</exclude-pattern>
+    <file>./Tests/</file>
+    <exclude-pattern>./Tests/VariableAnalysisSniff/fixtures/</exclude-pattern>
+    <exclude-pattern>./vendor/</exclude-pattern>
 
     <!-- Only check PHP files. -->
     <arg name="extensions" value="php"/>

VariableAnalysis/Tests/CodeAnalysis/fixtures/ClassWithMembersFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/ClassWithMembersFixture.php

@@ -6,6 +6,6 @@ parameters:
   paths:
     - %currentWorkingDirectory%/VariableAnalysis/
   excludes_analyse:
-    - %currentWorkingDirectory%/VariableAnalysis/Tests/
+    - %currentWorkingDirectory%/Tests/
   ignoreErrors:
     - '~^Constant T_\w+ not found.$~'

VariableAnalysis/Tests/CodeAnalysis/fixtures/CompactFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/CompactFixture.php

@@ -1,9 +1,9 @@
 <phpunit
-	bootstrap="VariableAnalysis/Tests/bootstrap.php"
+	bootstrap="Tests/bootstrap.php"
 	>
 	<testsuites>
 		<testsuite name="VariableAnalysis">
-			<directory>VariableAnalysis/Tests</directory>
+			<directory>Tests</directory>
 		</testsuite>
 	</testsuites>
 </phpunit>

VariableAnalysis/Tests/CodeAnalysis/fixtures/DestructuringFixture.php renamed to Tests/VariableAnalysisSniff/fixtures/DestructuringFixture.php

@@ -1,10 +1,10 @@
 <phpunit
-	bootstrap="VariableAnalysis/Tests/bootstrap.php"
+	bootstrap="Tests/bootstrap.php"
 	printerClass="LimeDeck\Testing\Printer"
 	>
 	<testsuites>
 		<testsuite name="VariableAnalysis">
-			<directory>VariableAnalysis/Tests</directory>
+			<directory>Tests</directory>
 		</testsuite>
 	</testsuites>
 </phpunit>