You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the _get_url_parameters function of bookmarks/services/favicon_loader.py file, it doesn't consider the web sites with specific port.
For example, website1:8100 might have favicon1.ico and website1:8200 have favicon2.ico. def _get_url_parameters(url: str) -> dict: parsed_uri = urlparse(url) return { # https://example.com/foo?bar -> https://example.com "url": f"{parsed_uri.scheme}://{parsed_uri.hostname}",
Suggest to change the code as below. def _get_url_parameters(url: str) -> dict: parsed_uri = urlparse(url) port = ':'+parsed_uri.port if parsed_uri.port else '' return { # https://example.com/foo?bar -> https://example.com "url": f"{parsed_uri.scheme}://{parsed_uri.hostname}{port}",
The text was updated successfully, but these errors were encountered:
In the _get_url_parameters function of bookmarks/services/favicon_loader.py file, it doesn't consider the web sites with specific port.
For example, website1:8100 might have favicon1.ico and website1:8200 have favicon2.ico.
def _get_url_parameters(url: str) -> dict: parsed_uri = urlparse(url) return { # https://example.com/foo?bar -> https://example.com "url": f"{parsed_uri.scheme}://{parsed_uri.hostname}",
Suggest to change the code as below.
def _get_url_parameters(url: str) -> dict: parsed_uri = urlparse(url) port = ':'+parsed_uri.port if parsed_uri.port else '' return { # https://example.com/foo?bar -> https://example.com "url": f"{parsed_uri.scheme}://{parsed_uri.hostname}{port}",
The text was updated successfully, but these errors were encountered: