Skip to content

Commit ad5f589

Browse files
committedJan 9, 2024
check-abi: Default to HEAD for new version
1 parent 9fb7e2f commit ad5f589

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed
 

‎tools/check-abi.sh

+4-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
set -eu
44

55
default_base_version="$(git describe --match "v*.*.*" --abbrev=0)"
6-
default_new_version="master"
6+
default_new_version="HEAD"
77

88
display_help_and_exit() {
99
echo "Usage: $0 <base_ver> <new_ver>"
@@ -33,7 +33,8 @@ else
3333
fi
3434

3535
checkout_and_build() {
36-
git worktree add -d "$1" "$2"
36+
_orig_dir="$(pwd)"
37+
git worktree add --detach "$1" "$2"
3738
cd "$1"
3839
mkdir build && cd build
3940
cmake -S .. --preset dev-mode \
@@ -45,20 +46,18 @@ checkout_and_build() {
4546
-DSECP256K1_BUILD_EXAMPLES=OFF
4647
cmake --build . -j "$(nproc)"
4748
abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2"
49+
cd "$_orig_dir"
4850
}
4951

5052
echo "Comparing $base_version (base version) to $new_version (new version)"
5153
echo
5254

53-
original_dir="$(pwd)"
54-
5555
base_source_dir=$(mktemp -d)
5656
checkout_and_build "$base_source_dir" "$base_version"
5757

5858
new_source_dir=$(mktemp -d)
5959
checkout_and_build "$new_source_dir" "$new_version"
6060

61-
cd "$original_dir"
6261
abi-compliance-checker -lib libsecp256k1 -old "${base_source_dir}/build/ABI.dump" -new "${new_source_dir}/build/ABI.dump"
6362
git worktree remove "$base_source_dir"
6463
git worktree remove "$new_source_dir"

0 commit comments

Comments
 (0)
Please sign in to comment.