The mainnet Spell reviewer and crafter checklists do not agree regarding the use of dss-interfaces.
On the reviewer checklist the use of dss-interfaces is mandatory, the CL states it SHOULD be used unless the function call is not present there:
On the crafter checklist, however, there are other situations in which the use of a static interface is acceptable:
- IF some actions require using interfaces
Since we rarely call more than a few functions in a contract, the crafter CL pushes the crafter to go against the review item, creating unnecessary friction during the review process. Both CLs should be aligned and push for a single pattern.
The mainnet Spell reviewer and crafter checklists do not agree regarding the use of dss-interfaces.
On the reviewer checklist the use of dss-interfaces is mandatory, the CL states it SHOULD be used unless the function call is not present there:
On the crafter checklist, however, there are other situations in which the use of a static interface is acceptable:
Since we rarely call more than a few functions in a contract, the crafter CL pushes the crafter to go against the review item, creating unnecessary friction during the review process. Both CLs should be aligned and push for a single pattern.