Skip to content

[Jobs][Consolidation] Fix controller failed on HA mode #7720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

[Jobs][Consolidation] Fix controller failed on HA mode #7720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sky/jobs/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ def is_consolidation_mode(on_api_restart: bool = False) -> bool:

def ha_recovery_for_consolidation_mode():
"""Recovery logic for HA mode."""
# Touch the signal file here to avoid conflict with
# update_managed_jobs_statuses. Although we run this first and then start
# the deamon, this function is also called in cancel_jobs_by_id.
signal_file = pathlib.Path(
constants.PERSISTENT_RUN_RESTARTING_SIGNAL_FILE).expanduser()
signal_file.touch()
# No setup recovery is needed in consolidation mode, as the API server
# already has all runtime installed. Directly start jobs recovery here.
# Refers to sky/templates/kubernetes-ray.yml.j2 for more details.
Expand Down Expand Up @@ -312,6 +318,7 @@ def ha_recovery_for_consolidation_mode():
f'{datetime.datetime.now()}\n')
f.write(f'HA recovery completed at {datetime.datetime.now()}\n')
f.write(f'Total recovery time: {time.time() - start} seconds\n')
signal_file.unlink()


async def get_job_status(
Expand Down