Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robot.brain.users is empty #352

Closed
3 tasks done
cesarvarela opened this issue Aug 29, 2016 · 4 comments
Closed
3 tasks done

robot.brain.users is empty #352

cesarvarela opened this issue Aug 29, 2016 · 4 comments
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@cesarvarela
Copy link

cesarvarela commented Aug 29, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

Running the https://www.npmjs.com/package/hubot-brain-inspect script shows that the users array is empty.

Reproducible in:

latest hubot-slack v4.0.2 deployed to Heroku

Expected result:

a list of users

Actual result:

{ users: {}, _private: {}, ambushes: {} }

Locally seems to be working:

robo> { users: { '1': User { id: '1', name: 'Shell', room: 'Shell' } }, _private: {} }

@mose
Copy link

mose commented Sep 3, 2016

I have the feeling this is a deliberate design. All the user object is fed by slack, updated on slack, and anything stored in brain for user would be subject to split-brain syndrome (like name change in slack and not in brain).

The issue I see is that there are various plugins that rely on existence of user in the brain for storing user extra information. There seem to be a trend towards considering this a bad practice.

But I wonder how realistic it is to expect all plugins to 'behave'. Maybe we could think of a hubot-slack-users new plugin that would ensure some compatibility and keep minimal user information in the brain, at least to have an object with an id ?

@telemaco
Copy link

i've the same problem. Any workarround? This bug (or design decission) brokes hubot-auth and other modules that depends of it.

@UncannyBingo UncannyBingo added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Priority—Medium labels Nov 3, 2016
@UncannyBingo
Copy link

This might be a bug, but it is unclear if we can do a whole lot about it, given the way the RTM API works. Might take a fair amount of work, but we should investigate this for sure!

@telemaco
Copy link

I think the problem is that this code has been removed. is it posible to restore it using RTM API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

No branches or pull requests

4 participants