LSP FMT: Indent with tabs instead of spaces

[cyann]

Feature Description

I'm using VS Code, and tried many settings to force the use of tabs instead of spaces for indentation.

"[slint]": {
	"editor.insertSpaces": false,
	"editor.detectIndentation": false,
}

Apparently the LSP FMT tool does not support that. It looks like the 4 spaces are hard-coded:

slint/tools/lsp/fmt/fmt.rs

Line 49 in b625ad9

new_line += " ";

I'm not sure what would be the easiest way to implement this. Maybe re-using the config from rustfmt - see hard_tabs? Or a command line parameter that we could set using slint.lsp-args?

Product Impact

No response

[cyann]

Workaround

Set the .slint files to not format on save, and change the File: Save shortcut to:

1. format
2. convert indentation to tabs
3. save

settings.json

	"[slint]": {
		"editor.formatOnSave": false
	}

keybindings.json

{
	"key": "cmd+s",
	"command": "runCommands",
	"args": {
		"commands": [
			"editor.action.formatDocument",
			"editor.action.indentationToTabs",
			"workbench.action.files.save"
		]
	},
	"when": "editorTextFocus && editorLangId == 'slint'"
}

[ogoffart]

I agree, we should have settings for the formatter for this kind of stuff.