gomods -go fix ./... (#2336)

Author: jmank88

keystore/corekeys/models/models.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"math/big"
+	"slices"
 	"time"
 
 	gethkeystore "github.com/ethereum/go-ethereum/accounts/keystore"
@@ -140,9 +141,9 @@ func (ks *KeyStates) Enable(addr common.Address, chainID *big.Int, updatedAt tim
 // warning: not thread-safe! caller must sync
 func (ks *KeyStates) Delete(addr common.Address) {
 	var chainIDs []*big.Int
-	for i := len(ks.All) - 1; i >= 0; i-- {
-		if ks.All[i].Address.Address() == addr {
-			chainIDs = append(chainIDs, ks.All[i].EVMChainID.ToInt())
+	for i, v := range slices.Backward(ks.All) {
+		if v.Address.Address() == addr {
+			chainIDs = append(chainIDs, v.EVMChainID.ToInt())
 			ks.All = append(ks.All[:i], ks.All[i+1:]...)
 		}
 	}

pkg/beholder/batch_emitter_service.go

@@ -171,8 +171,7 @@ func (e *ChipIngressBatchEmitterService) emitInternal(ctx context.Context, body
 				// every dropped event. chip_ingress.events_dropped (error_code) already
 				// captures that it's happening and roughly why; the full reason isn't
 				// needed at fleet-wide log volume.
-				var pubErr *batch.PublishError
-				if !errors.As(sendErr, &pubErr) {
+				if _, ok := errors.AsType[*batch.PublishError](sendErr); !ok {
 					e.eng.Errorw("failed to emit to chip ingress",
 						"error", sendErr,
 						"error_code", errorCode,

pkg/beholder/metered_exporter_test.go

@@ -498,11 +498,9 @@ func TestExportStatsHandler_ConcurrentRPCsIsolated(t *testing.T) {
 	for i := 1; i <= n; i++ {
 		size := i
 		want += int64(size)
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
+		wg.Go(func() {
 			simulateRPC(h, context.Background(), size, nil)
-		}()
+		})
 	}
 	wg.Wait()
 

pkg/capabilities/cli/cmd/go_reader.go

@@ -116,7 +116,7 @@ func (g *GoStructReader) configName(field *ast.Field) string {
 	tag := reflect.StructTag(field.Tag.Value[1 : len(field.Tag.Value)-1])
 	jsonTag := tag.Get("json")
 	if jsonTag != "" {
-		jsonName := strings.Split(jsonTag, ",")[0]
+		jsonName, _, _ := strings.Cut(jsonTag, ",")
 		if jsonName != "" {
 			return jsonName
 		}

pkg/capabilities/v2/gen/main.go

@@ -27,7 +27,7 @@ func generateFlat(gen *pkg.ProtocGen, proto, outDir string) error {
 		return err
 	}
 
-	topDir := strings.Split(proto, string(os.PathSeparator))[0]
+	topDir, _, _ := strings.Cut(proto, string(os.PathSeparator))
 	return os.RemoveAll(topDir)
 }
 

pkg/chipingress/batch/client.go

@@ -65,8 +65,7 @@ func ErrorCodeFor(err error) string {
 		return ""
 	}
 
-	var pubErr *PublishError
-	if errors.As(err, &pubErr) {
+	if pubErr, ok := errors.AsType[*PublishError](err); ok {
 		if pubErr.Code == ErrCodeResultsMismatch {
 			return "results_mismatch"
 		}

pkg/codec/multi_modifier.go

@@ -2,6 +2,7 @@ package codec
 
 import (
 	"reflect"
+	"slices"
 )
 
 // MultiModifier is a Modifier that applies each element for the slice in-order (reverse order for TransformForOnChain).
@@ -13,9 +14,9 @@ func (c MultiModifier) RetypeToOffChain(onChainType reflect.Type, itemType strin
 
 func (c MultiModifier) TransformToOnChain(offChainValue any, itemType string) (any, error) {
 	onChainValue := offChainValue
-	for i := len(c) - 1; i >= 0; i-- {
+	for _, v := range slices.Backward(c) {
 		var err error
-		if onChainValue, err = c[i].TransformToOnChain(onChainValue, itemType); err != nil {
+		if onChainValue, err = v.TransformToOnChain(onChainValue, itemType); err != nil {
 			return nil, err
 		}
 	}

pkg/config/toml.go

@@ -12,8 +12,7 @@ import (
 func DecodeTOML(r io.Reader, v any) error {
 	d := toml.NewDecoder(r).DisallowUnknownFields()
 	if err := d.Decode(v); err != nil {
-		var strict *toml.StrictMissingError
-		if errors.As(err, &strict) {
+		if strict, ok := errors.AsType[*toml.StrictMissingError](err); ok {
 			return errors.New(strict.String())
 		}
 		return err

pkg/loop/internal/core/services/capability/capabilities.go

@@ -226,8 +226,7 @@ func (t *triggerExecutableServer) RegisterTrigger(request *pb.TriggerRegistratio
 
 		// If it's a capability error, serialize it and send it to the client for proper deserialization and handling on the client side.
 		errorString := err.Error()
-		var capErr caperrors.Error
-		if errors.As(err, &capErr) {
+		if capErr, ok := errors.AsType[caperrors.Error](err); ok {
 			errorString = capErr.SerializeToString()
 		}
 		msg := &pb.TriggerResponseMessage{
@@ -448,8 +447,7 @@ func (c *executableServer) Execute(reqpb *pb.CapabilityRequest, server pb.Execut
 	var responseMessage *pb.CapabilityResponse
 	response, err := c.impl.Execute(server.Context(), req)
 	if err != nil {
-		var capabilityError caperrors.Error
-		if errors.As(err, &capabilityError) {
+		if capabilityError, ok := errors.AsType[caperrors.Error](err); ok {
 			responseMessage = &pb.CapabilityResponse{Error: capabilityError.SerializeToString()}
 		} else {
 			// All other errors are treated as private visibility and are marked as such to prevent accidental or malicious

pkg/loop/internal/relayer/pluginprovider/contractreader/contract_reader_test.go

@@ -8,6 +8,7 @@ import (
 	"maps"
 	"math/big"
 	"reflect"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -533,9 +534,9 @@ func (f *fakeContractReader) GetLatestValue(_ context.Context, readIdentifier st
 	if strings.HasSuffix(readIdentifier, MethodReturningAlterableUint64) {
 		r := returnVal.(*uint64)
 		vals := f.vals[contractName]
-		for i := len(vals) - 1; i >= 0; i-- {
-			if vals[i].confidenceLevel == confidenceLevel {
-				*r = vals[i].val
+		for _, val := range slices.Backward(vals) {
+			if val.confidenceLevel == confidenceLevel {
+				*r = val.val
 				return nil
 			}
 		}
@@ -577,9 +578,9 @@ func (f *fakeContractReader) GetLatestValue(_ context.Context, readIdentifier st
 			return types.ErrNotFound
 		}
 
-		for i := len(events) - 1; i >= 0; i-- {
-			if events[i].confidenceLevel == confidenceLevel {
-				*returnVal.(*TestStruct) = events[i].event.(TestStruct)
+		for _, event := range slices.Backward(events) {
+			if event.confidenceLevel == confidenceLevel {
+				*returnVal.(*TestStruct) = event.event.(TestStruct)
 				return nil
 			}
 		}
@@ -590,8 +591,8 @@ func (f *fakeContractReader) GetLatestValue(_ context.Context, readIdentifier st
 		defer f.lock.Unlock()
 		param := params.(*FilterEventParams)
 		triggers := f.triggers.getEvents(func(e event) bool { return e.contractID == contractName && e.eventType == EventName })
-		for i := len(triggers) - 1; i >= 0; i-- {
-			testStruct := triggers[i].event.(TestStruct)
+		for _, trigger := range slices.Backward(triggers) {
+			testStruct := trigger.event.(TestStruct)
 			if *testStruct.Field == param.Field {
 				*returnVal.(*TestStruct) = testStruct
 				return nil
@@ -608,9 +609,9 @@ func (f *fakeContractReader) GetLatestValue(_ context.Context, readIdentifier st
 			return types.ErrNotFound
 		}
 
-		for i := len(triggers) - 1; i >= 0; i-- {
-			if triggers[i].confidenceLevel == confidenceLevel {
-				*returnVal.(*SomeDynamicTopicEvent) = triggers[i].event.(SomeDynamicTopicEvent)
+		for _, trigger := range slices.Backward(triggers) {
+			if trigger.confidenceLevel == confidenceLevel {
+				*returnVal.(*SomeDynamicTopicEvent) = trigger.event.(SomeDynamicTopicEvent)
 				return nil
 			}
 		}