Lesson 9: Same issue discussed in #1714 - "before each" hook for "initializes the raffle correctly"

[cryptocambi]

Hi,

Is not really clear the process I have to follow to resolve the issue discussed in #1714:

#1714

I have create a pull request from my github account, but nothing happen. It ask me to compare changes but I have just my main branch and nothing else to compare.

I know I missing something, some help pls.

Here my repository:

https://github.com/cryptocambi/Hardhat-SmartContract-Lottery

Thank

[HarshDev56]

@cryptocambi are you facing this issue "before each" hook for "initializes the raffle correctly" ?

[cryptocambi]

yes!

[HarshDev56]

@cryptocambi you need to change in this file 00-deploy-mocks.js
replace this

module.exports.tags = ["All", "mocks"]

with

 module.exports.tags = ["all", "mocks"]

because you call await deployments.fixture(["all"]) this with all and in your 00-deploy-mocks.js file it is capital All so that is creating issue . and i also create a pull request for you your repo you can merge that also . if you found this answer help full then please mark it as Answer/solved . so others can get the answer

[cryptocambi]

thank man it works

[HarshDev56]

@cryptocambi one more suggestion please don't show you .env file in github you can hide it add .env in your .gitignore file .

[cryptocambi]

yes, Thank!
Last questions, how do I pull a request and how do I merge it and why I am doing it?

[HarshDev56]

@cryptocambi like i first create a copy of your code in my GitHub and then create a copy in my local system for running and test your code then i find a solution and i solved it and now i want that my changes are also be in your code so i make changes and push it to my copy of your code and now for your codebase i create a pull request (which you can see in your repo above the 3rd option from there you can merge my solved code in to your code so your issue will fix ) . in your repo when you click on 3rd option above the "pull request" there is a option for merge from there you can merge .

[cryptocambi]

Hi Harsh, I have some issue with when I run the command: yarn hardhat deploy --network sepolia in the terminal I have got: An unexpected error occurred: Error: ERROR processing C:\Users\K\hh-fcc\hardhat-smartcontract-lottary-fcc\deploy\01.deploy.raffle.js: TypeError: Cannot read properties of undefined (reading 'vrfCoordinatorV2') I would like to ask help to the community. How do I update my contract on GitHub? Thank you

…

On Thu, 18 May 2023 at 11:19, Harsh Fichadiya ***@***.***> wrote: @cryptocambi <https://github.com/cryptocambi> like i first create a copy of your code in my GitHub and then create a copy in my local system for running and test your code then i find a solution and i solved it and now i want that my changes are also be in your code so i make changes and push it to my copy of your code and now for your codebase i create a pull request (which you can see in your repo above the 3rd option from there you can merge my solved code in to your code so your issue will fix ) . in your repo when you click on 3rd option above the "pull request" there is a option for merge from there you can merge . — Reply to this email directly, view it on GitHub <#5506 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4HG4OR4TMEPYZBAQSLQGCTXGXSTJANCNFSM6AAAAAAYGDW6JI> . You are receiving this because you were mentioned.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/5506/comments/5937130 @github.com>

[HarshDev56]

@cryptocambi this is the best video for learning git and github https://www.youtube.com/watch?v=apGV9Kg7ics&pp=ygUMZ2l0aHViIGt1bmFs learn and push your updated code and ping me again i will check your issue but i run your current code from github and it is working fine on that command

[HarshDev56]

and from now you can create a new discussion for discussing on any other issues it will help others also.

[cryptocambi]

Hi HarshDev56,
I managed to upload the updates, thank for the link really useful
I also open a new discussion, can you please check it out when you got time (#5589)

Thank man