Remove getFieldValue.

Author: Fahad Zubair

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/StructureGenerator.kt

@@ -109,9 +109,20 @@ open class StructureGenerator(
         ) {
             writer.rustBlock("fn fmt(&self, f: &mut #1T::Formatter<'_>) -> #1T::Result", RuntimeType.stdFmt) {
                 rust("""let mut formatter = f.debug_struct(${name.dq()});""")
+
                 members.forEach { member ->
                     val memberName = symbolProvider.toMemberName(member)
-                    val fieldValue = getFieldValue(member, memberName)
+                    // If the struct is marked sensitive all fields get redacted, otherwise each field is determined on its own
+                    val fieldValue =
+                        if (shape.shouldRedact(model)) {
+                            REDACTION
+                        } else {
+                            member.redactIfNecessary(
+                                model,
+                                "self.$memberName",
+                            )
+                        }
+
                     rust(
                         "formatter.field(${memberName.dq()}, &$fieldValue);",
                     )
@@ -127,15 +138,6 @@ open class StructureGenerator(
         member: MemberShape,
         memberName: String?,
     ): String {
-        val fieldValue =
-            if (shape.shouldRedact(model)) {
-                REDACTION
-            } else {
-                member.redactIfNecessary(
-                    model,
-                    "self.$memberName",
-                )
-            }
         return fieldValue
     }
 

codegen-server/python/src/main/kotlin/software/amazon/smithy/rust/codegen/server/python/smithy/generators/PythonServerEnumGenerator.kt

@@ -59,27 +59,20 @@ class PythonConstrainedEnum(
         }
 
     private fun pyEnumName(context: EnumGeneratorContext): Writable =
-        // Only named enums have a `name` property. Do not generate `fn name` for
-        // unnamed enums.
-        if (context.enumTrait.hasNames()) {
-            writable {
-                rustBlock(
-                    """
-                    ##[getter]
-                    pub fn name(&self) -> &str
-                    """,
-                ) {
-                    rustBlock("match self") {
-                        context.sortedMembers.forEach { member ->
-                            val memberName = member.name()?.name
-                            check(memberName != null) { "${context.enumTrait} cannot have null members" }
-                            rust("""${context.enumName}::$memberName => ${memberName?.dq()},""")
-                        }
+        writable {
+            rustBlock(
+                """
+                ##[getter]
+                pub fn name(&self) -> &str
+                """,
+            ) {
+                rustBlock("match self") {
+                    context.sortedMembers.forEach { member ->
+                        val memberName = member.name()?.name
+                        rust("""${context.enumName}::$memberName => ${memberName?.dq()},""")
                     }
                 }
             }
-        } else {
-            writable {}
         }
 }