Technician incorrectly checks basePower instead of move.bp

[hzla]

damage-calc/calc/src/mechanics/gen4.ts

Line 468 in 8338028

(attacker.hasAbility('Technician') && basePower <= 60)

Technician is checking if basePower is under 60 which could have possibly been boosted in previous checks for helping hand and damage boosting items resulting in technician boosts sometimes not being applied. Should be checking move.bp instead.

[urkerab]

Bulbapedia seems to think that this is actually correct Gen 4 behaviour, although I don't see any code for it in Pokémon Showdown; maybe I overlooked it.

[hzla]

Actually you're right, after checking https://github.com/pret/pokeplatinum/blob/5885ad26caff0d608ff66808e2e6507fc968cc4e/src/battle/battle_lib.c#L6697 it seems technician is indeed applied after helping hand, type item boosts, and charge.

[hzla]

Actually sorry, it looks like it's being checked after charge and helping hand, but before type item boosts.

Here is where type item boosts are applied
https://github.com/pret/pokeplatinum/blob/5885ad26caff0d608ff66808e2e6507fc968cc4e/src/battle/battle_lib.c#L6715

Here is where technician is applied beforehand
https://github.com/pret/pokeplatinum/blob/5885ad26caff0d608ff66808e2e6507fc968cc4e/src/battle/battle_lib.c#L6697