Skip to content

Commit 5fed35b

Browse files
authored
Apply suggestions from code review
1 parent cf5a5f6 commit 5fed35b

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

play.pokemonshowdown.com/src/battle-dex-search.ts

+6-13
Original file line numberDiff line numberDiff line change
@@ -1320,24 +1320,17 @@ class BattleItemSearch extends BattleTypedSearch<'item'> {
13201320
if (item.itemUser?.includes(speciesName)) speciesSpecific.push(row);
13211321
if (abilityItem === item.id) abilitySpecific.push(row);
13221322
}
1323-
1324-
const specificItems: SearchRow[] = [];
1325-
13261323
if (speciesSpecific.length) {
1327-
specificItems.unshift(
1324+
return [
13281325
['header', "Specific to " + speciesName],
1329-
...speciesSpecific
1330-
);
1326+
...speciesSpecific,
1327+
...results,
1328+
];
13311329
}
13321330
if (abilitySpecific.length) {
1333-
specificItems.unshift(
1334-
['header', `Specific to ${this.set!.ability!}`],
1335-
...abilitySpecific
1336-
);
1337-
}
1338-
if (specificItems.length) {
13391331
return [
1340-
...specificItems,
1332+
['header', `Specific to ${this.set!.ability!}`],
1333+
...abilitySpecific,
13411334
...results,
13421335
];
13431336
}

0 commit comments

Comments
 (0)