Skip to content

Commit a10821a

Browse files
authored
Update to ESLint 9 (#2326)
This finally removes the tslint dependency and switches to eslint. There are a lot of other changes here, too, to bring the codebase up to server standards. TSLint never had much in the way of indentation enforcement. Not very happy about eslint splitting itself up over 6 dependencies, or its documentation over three websites, nor how poorly documented the new flat config is, but I mean, eslint's gonna eslint. Customizing would be even harder if we tried to use Biome or something. They mostly seem to go full Prettier. Also here are some changes to our style rules. In particular: - Curly brackets (for objects etc) now have spaces inside them. Sorry for the huge change. ESLint doesn't support our old style, and most projects use Prettier style, so we might as well match them in this way. See eslint-stylistic/eslint-stylistic#415 - String + number concatenation is no longer allowed (except in ES3 code). We otherwise now consistently use template strings for this.
1 parent 3d4de88 commit a10821a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+6941
-5351
lines changed

.eslintignore

-16
This file was deleted.

.eslintrc.js

-210
This file was deleted.

.github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [14.x]
19+
node-version: [22.x]
2020

2121
steps:
2222
- uses: actions/checkout@v2

.vscode/settings.json

-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@
22
"editor.formatOnSave": false,
33
"showdown.server": "", // e.g., "?~~localhost:8000"
44
"showdown.clientUrl": "http://localhost:8080",
5-
"tslint.configFile": "tslint.json",
65
"typescript.tsdk": "node_modules/typescript/lib"
76
}

build-tools/.eslintrc.js

-44
This file was deleted.

0 commit comments

Comments
 (0)