Protosynthesis should ignore weather supressing abilities

Author: HoeenCoder

data/abilities.ts

@@ -3420,8 +3420,9 @@ export const Abilities: {[abilityid: string]: AbilityData} = {
 			this.singleEvent('WeatherChange', this.effect, this.effectState, pokemon);
 		},
 		onWeatherChange(pokemon) {
-			// Protosynthesis is not affected by Utility Umbrella
-			if (this.field.isWeather('sunnyday')) {
+			// Protosynthesis is not affected by Utility Umbrella, or any weather supressing ability
+			// As a result, we check the weather directly instead of via field#isWeather which calls field#effectiveWeather
+			if (this.field.weather === 'sunnyday') {
 				pokemon.addVolatile('protosynthesis');
 			} else if (!pokemon.volatiles['protosynthesis']?.fromBooster) {
 				pokemon.removeVolatile('protosynthesis');

test/sim/abilities/protosynthesis.js

@@ -77,6 +77,18 @@ describe('Protosynthesis', function () {
 		assert.equal(tail.volatiles['protosynthesis'].bestStat, 'spd', `Scream Tail's SpD should have been boosted by Protosynthesis in Sun while holding Utility Umbrella`);
 	});
 
+	it(`should not be prevented from activating by weather suppressing abilities`, function () {
+		battle = common.createBattle([[
+			{species: 'Scream Tail', ability: 'protosynthesis', moves: ['splash']},
+		], [
+			{species: 'Altaria', ability: 'cloudnine', moves: ['sunnyday']},
+		]]);
+
+		const tail = battle.p1.active[0];
+		battle.makeChoices('move splash', 'move sunnyday');
+		assert.equal(tail.volatiles['protosynthesis'].bestStat, 'spd', `Scream Tail's SpD should have been boosted by Protosynthesis in Sun even though a weather supressing ability was active`);
+	});
+
 	it(`should have its boost nullified by Neutralizing Gas`, function () {
 		battle = common.createBattle([[
 			{species: 'Scream Tail', ability: 'protosynthesis', item: 'boosterenergy', moves: ['luckychant', 'recover']},