SNOW-1937440 Drop support for Go 1.21, add support for 1.24 (#1308)

Author: sfc-gh-pfus

.github/workflows/build-test.yml

@@ -48,7 +48,7 @@ jobs:
             fail-fast: false
             matrix:
                 cloud: [ 'AWS', 'AZURE', 'GCP' ]
-                go: [ '1.21', '1.22', '1.23' ]
+                go: [ '1.22', '1.23', '1.24' ]
         name: ${{ matrix.cloud }} Go ${{ matrix.go }} on Ubuntu
         steps:
             - uses: actions/checkout@v4
@@ -79,7 +79,7 @@ jobs:
             fail-fast: false
             matrix:
                 cloud: [ 'AWS', 'AZURE', 'GCP' ]
-                go: [ '1.21', '1.22', '1.23' ]
+                go: [ '1.22', '1.23', '1.24' ]
         name: ${{ matrix.cloud }} Go ${{ matrix.go }} on Mac
         steps:
             - uses: actions/checkout@v4
@@ -109,7 +109,7 @@ jobs:
             fail-fast: false
             matrix:
                 cloud: [ 'AWS', 'AZURE', 'GCP' ]
-                go: [ '1.21', '1.22', '1.23' ]
+                go: [ '1.22', '1.23', '1.24' ]
         name: ${{ matrix.cloud }} Go ${{ matrix.go }} on Windows
         steps:
             - uses: actions/checkout@v4

Jenkinsfile

@@ -14,7 +14,7 @@ timestamps {
       string(name: 'branch', value: 'main'),
       string(name: 'client_git_commit', value: scmInfo.GIT_COMMIT),
       string(name: 'client_git_branch', value: scmInfo.GIT_BRANCH),
-      string(name: 'TARGET_DOCKER_TEST_IMAGE', value: 'go-centos7-go1.21'),
+      string(name: 'TARGET_DOCKER_TEST_IMAGE', value: 'go-chainguard-go1_24'),
       string(name: 'parent_job', value: env.JOB_NAME),
       string(name: 'parent_build_number', value: env.BUILD_NUMBER)
     ]

README.md

@@ -25,7 +25,7 @@ The following software packages are required to use the Go Snowflake Driver.
 
 ## Go
 
-The latest driver requires the [Go language](https://golang.org/) 1.20 or higher. The supported operating systems are Linux, Mac OS, and Windows, but you may run the driver on other platforms if the Go language works correctly on those platforms.
+The latest driver requires the [Go language](https://golang.org/) 1.22 or higher. The supported operating systems are Linux, Mac OS, and Windows, but you may run the driver on other platforms if the Go language works correctly on those platforms.
 
 
 # Installation

ci/_init.sh

@@ -1,4 +1,4 @@
-#!/bin/bash -e
+#!/usr/bin/env -e
 
 export PLATFORM=$(echo $(uname) | tr '[:upper:]' '[:lower:]')
 # Use the internal Docker Registry
@@ -10,6 +10,6 @@ export DRIVER_NAME=go
 
 TEST_IMAGE_VERSION=1
 declare -A TEST_IMAGE_NAMES=(
-    [$DRIVER_NAME-centos7-go1.21]=$DOCKER_REGISTRY_NAME/client-$DRIVER_NAME-centos7-go1.21-test:$TEST_IMAGE_VERSION
+    [$DRIVER_NAME-chainguard-go1_24]=$DOCKER_REGISTRY_NAME/client-$DRIVER_NAME-chainguard-go1.24-test:$TEST_IMAGE_VERSION
 )
 export TEST_IMAGE_NAMES

ci/image/Dockerfile

@@ -0,0 +1,17 @@
+FROM artifactory.int.snowflakecomputing.com/development-chainguard-virtual/snowflake.com/go:1.24.0-dev
+
+USER root
+
+RUN apk update && apk add python3 python3-dev jq aws-cli gosu py3-pip
+RUN python3 -m ensurepip
+RUN pip install -U snowflake-connector-python
+
+# workspace
+RUN mkdir -p /home/user && \
+    chmod 777 /home/user
+WORKDIR /mnt/host
+
+# entry point
+COPY scripts/entrypoint.sh /usr/local/bin/entrypoint.sh
+RUN chmod +x /usr/local/bin/entrypoint.sh
+ENTRYPOINT ["/usr/local/bin/entrypoint.sh"]

ci/image/Dockerfile.go-centos7-go1.21-test

@@ -1,4 +1,4 @@
-#!/bin/bash -e
+#!/usr/bin/env bash -e
 #
 # Build Docker images
 #
@@ -9,7 +9,7 @@ source $THIS_DIR/../_init.sh
 for name in "${!TEST_IMAGE_NAMES[@]}"; do
     docker build \
         --platform linux/amd64 \
-        --file $THIS_DIR/Dockerfile.$name-test \
+        --file $THIS_DIR/Dockerfile \
         --label snowflake \
         --label $DRIVER_NAME \
         --tag ${TEST_IMAGE_NAMES[$name]} .

ci/image/build.sh

@@ -1,4 +1,4 @@
-#!/bin/bash -e
+#!/usr/bin/env bash -e
 #
 # Build Docker images
 #

ci/image/update.sh

@@ -2480,3 +2480,18 @@ func TestIsArrayOfStructs(t *testing.T) {
 		})
 	}
 }
+
+func TestSqlNull(t *testing.T) {
+	runDBTest(t, func(dbt *DBTest) {
+		rows := dbt.mustQuery("SELECT 1, NULL UNION SELECT 2, 'test' ORDER BY 1")
+		defer rows.Close()
+		var rowID int
+		var nullStr sql.Null[string]
+		assertTrueF(t, rows.Next())
+		assertNilF(t, rows.Scan(&rowID, &nullStr))
+		assertEqualE(t, nullStr, sql.Null[string]{Valid: false})
+		assertTrueF(t, rows.Next())
+		assertNilF(t, rows.Scan(&rowID, &nullStr))
+		assertEqualE(t, nullStr, sql.Null[string]{Valid: true, V: "test"})
+	})
+}

converter_test.go

@@ -3,6 +3,7 @@
 package gosnowflake
 
 import (
+	"cmp"
 	"context"
 	"crypto/rsa"
 	"database/sql"
@@ -52,10 +53,7 @@ const (
 func init() {
 	// get environment variables
 	env := func(key, defaultValue string) string {
-		if value := os.Getenv(key); value != "" {
-			return value
-		}
-		return defaultValue
+		return cmp.Or(os.Getenv(key), defaultValue)
 	}
 	username = env("SNOWFLAKE_TEST_USER", "testuser")
 	pass = env("SNOWFLAKE_TEST_PASSWORD", "testpassword")
@@ -107,10 +105,7 @@ func createDSN(timezone string) {
 // setup creates a test schema so that all tests can run in the same schema
 func setup() (string, error) {
 	env := func(key, defaultValue string) string {
-		if value := os.Getenv(key); value != "" {
-			return value
-		}
-		return defaultValue
+		return cmp.Or(os.Getenv(key), defaultValue)
 	}
 
 	orgSchemaname := schemaname

driver_test.go

@@ -1,6 +1,6 @@
 module github.com/snowflakedb/gosnowflake
 
-go 1.21
+go 1.22
 
 require (
 	github.com/99designs/keyring v1.2.2

go.mod

@@ -20,7 +20,7 @@ import (
 type ObjectType struct {
 }
 
-var structuredObjectWriterType = reflect.TypeOf((*StructuredObjectWriter)(nil)).Elem()
+var structuredObjectWriterType = reflect.TypeFor[StructuredObjectWriter]()
 
 // StructuredObject is a representation of structured object for reading.
 type StructuredObject interface {