SNOW-1313927 Do not close channel twice in async handling (#1098)

sfc-gh-pfus · web-flow · commit a40b1d5a2d1f · 2024-04-15T12:02:50.000+02:00
diff --git a/async.go b/async.go
@@ -102,15 +102,13 @@ func (sr *snowflakeRestful) getAsync(
 			if isMultiStmt(&respd.Data) {
 				if err = sc.handleMultiQuery(ctx, respd.Data, rows); err != nil {
 					rows.errChannel <- err
-					close(rows.errChannel)
 					return err
 				}
 			} else {
 				rows.addDownloader(populateChunkDownloader(ctx, sc, respd.Data))
 			}
 			if err = rows.ChunkDownloader.start(); err != nil {
 				rows.errChannel <- err
-				close(rows.errChannel)
 				return err
 			}
 			rows.errChannel <- nil // mark query status complete

Original file line number	Diff line number	Diff line change
`@@ -102,15 +102,13 @@ func (sr *snowflakeRestful) getAsync(`
`102`	`102`	`if isMultiStmt(&respd.Data) {`
`103`	`103`	`if err = sc.handleMultiQuery(ctx, respd.Data, rows); err != nil {`
`104`	`104`	`rows.errChannel <- err`
`105`		`- close(rows.errChannel)`
`106`	`105`	`return err`
`107`	`106`	`}`
`108`	`107`	`} else {`
`109`	`108`	`rows.addDownloader(populateChunkDownloader(ctx, sc, respd.Data))`
`110`	`109`	`}`
`111`	`110`	`if err = rows.ChunkDownloader.start(); err != nil {`
`112`	`111`	`rows.errChannel <- err`
`113`		`- close(rows.errChannel)`
`114`	`112`	`return err`
`115`	`113`	`}`
`116`	`114`	`rows.errChannel <- nil // mark query status complete`