Add golangci-lint (#1228)

Author: sfc-gh-pfus

.github/workflows/build-test.yml

@@ -35,6 +35,10 @@ jobs:
             uses: actions/setup-go@v5
             with:
               go-version: '1.21'
+          - name: golangci-lint
+            uses: golangci/golangci-lint-action@v6
+            with:
+              version: v1.60
           - name: Format, Lint
             shell: bash
             run: ./ci/build.sh

.golangci.yml

@@ -0,0 +1,10 @@
+run:
+  tests: true
+
+issues:
+  exclude-rules:
+    # we own this driver so we need to test this functions
+    - path: statement_test.go
+      text: "Drivers should implement StmtExecContext instead"
+    - path: statement_test.go
+      text: "Drivers should implement StmtQueryContext instead"

aaa_test.go

@@ -7,11 +7,13 @@ import (
 func TestShowServerVersion(t *testing.T) {
 	runDBTest(t, func(dbt *DBTest) {
 		rows := dbt.mustQuery("SELECT CURRENT_VERSION()")
-		defer rows.Close()
+		defer func() {
+			assertNilF(t, rows.Close())
+		}()
 
 		var version string
 		rows.Next()
-		rows.Scan(&version)
+		assertNilF(t, rows.Scan(&version))
 		println(version)
 	})
 }

async.go

@@ -40,7 +40,10 @@ func (sr *snowflakeRestful) processAsync(
 	go GoroutineWrapper(
 		ctx,
 		func() {
-			sr.getAsync(ctx, headers, sr.getFullURL(respd.Data.GetResultURL, nil), timeout, res, rows, cfg)
+			err := sr.getAsync(ctx, headers, sr.getFullURL(respd.Data.GetResultURL, nil), timeout, res, rows, cfg)
+			if err != nil {
+				logger.Errorf("error while calling getAsync. %v", err)
+			}
 		},
 	)
 	return respd, nil

auth.go

@@ -371,7 +371,6 @@ func authenticate(
 		}
 		code, err := strconv.Atoi(respd.Code)
 		if err != nil {
-			code = -1
 			return nil, err
 		}
 		return nil, (&SnowflakeError{

authexternalbrowser.go

@@ -36,7 +36,7 @@ const (
 
 // Builds a response to show to the user after successfully
 // getting a response from Snowflake.
-func buildResponse(application string) bytes.Buffer {
+func buildResponse(application string) (bytes.Buffer, error) {
 	body := fmt.Sprintf(successHTML, application)
 	t := &http.Response{
 		Status:        "200 OK",
@@ -50,8 +50,8 @@ func buildResponse(application string) bytes.Buffer {
 		Header:        make(http.Header),
 	}
 	var b bytes.Buffer
-	t.Write(&b)
-	return b
+	err := t.Write(&b)
+	return b, err
 }
 
 // This opens a socket that listens on all available unicast
@@ -135,7 +135,6 @@ func getIdpURLProofKey(
 		sr.TokenAccessor.SetTokens("", "", -1)
 		code, err := strconv.Atoi(respd.Code)
 		if err != nil {
-			code = -1
 			return "", "", err
 		}
 		return "", "", &SnowflakeError{
@@ -311,10 +310,17 @@ func doAuthenticateByExternalBrowser(
 			buf.Grow(bufSize)
 		}
 		if encodedSamlResponse != "" {
-			httpResponse := buildResponse(application)
-			c.Write(httpResponse.Bytes())
+			httpResponse, err := buildResponse(application)
+			if err != nil && errAccept == nil {
+				errAccept = err
+			}
+			if _, err = c.Write(httpResponse.Bytes()); err != nil && errAccept == nil {
+				errAccept = err
+			}
+		}
+		if err := c.Close(); err != nil {
+			logger.Warnf("error while closing browser connection. %v", err)
 		}
-		c.Close()
 		encodedSamlResponseChan <- encodedSamlResponse
 		errChan <- errAccept
 	}(conn)

authexternalbrowser_test.go

@@ -51,7 +51,8 @@ func TestGetTokenFromResponse(t *testing.T) {
 }
 
 func TestBuildResponse(t *testing.T) {
-	resp := buildResponse("Go")
+	resp, err := buildResponse("Go")
+	assertNilF(t, err)
 	bytes := resp.Bytes()
 	respStr := string(bytes[:])
 	if !strings.Contains(respStr, "Your identity was confirmed and propagated to Snowflake Go.\nYou can close this window now and go back where you started from.") {

authokta.go

@@ -97,7 +97,6 @@ func authenticateBySAML(
 		sr.TokenAccessor.SetTokens("", "", -1)
 		code, err := strconv.Atoi(respd.Code)
 		if err != nil {
-			code = -1
 			return nil, err
 		}
 		return nil, &SnowflakeError{