remove original request from Response #488
Conversation
avieth
force-pushed
the
avieth/original-request
branch
from
eeae3d5 to
30c6bbb
Compare
Deliver it instead by way of the Manager's response modifier. See snoyberg#464 This patch accomplishes the same thing as that one in essentially the same way, but improves upon it by not requiring a request to exist in order to construct a response. This can be useful in e.g. testing / mocking definitions in which we want to express a base fixed response. In other wrods, it is "less breaky" and easier to adopt.
avieth
force-pushed
the
avieth/original-request
branch
from
30c6bbb to
beadedb
Compare
|
@snoyberg any chance that this will still land. For now, I can deal with always needing a However, personally, I would still prefer if I could construct a |
|
Hey @sol, reality is that I don't have much time for maintenance of this library. If you're interested in stepping in as a comaintainer, I'd be happy to add you here and on Hackage. |
Hey @snoyberg, works for me. My first priority will be fixing CI, but I will be busy for the rest of the day, so gonna look into it tomorrow. |
|
Great, thanks @sol! I just added you as a collaborator. When you're ready for Hackage access, just let me know which of the packages in this repo you'd like upload rights for and your Hackage username. |
|
@miguelclean does this work for you as an alternative for #464. |
3 participants
Deliver it instead by way of the Manager's response modifier.
See #464
This patch accomplishes the same thing as that one in essentially the
same way, but improves upon it by not requiring a request to exist in
order to construct a response. This can be useful in e.g. testing /
mocking definitions in which we want to express a base fixed response.
In other words, it is "less breaky" and easier to adopt.