Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better graphical separation of different commits #368

Open
bruce-ricard opened this issue Apr 23, 2020 · 2 comments
Open

Better graphical separation of different commits #368

bruce-ricard opened this issue Apr 23, 2020 · 2 comments

Comments

@bruce-ricard
Copy link

bruce-ricard commented Apr 23, 2020

I recently started using diff-so-fancy. I really like the way new files are being shown. I used to miss them when scrolling quickly even with diff-highlight, that doesn't happen anymore.

What happens to me now is that I miss the beginning of a new commit when running a command like git log -p.

Suggestion: similarly to how files are shown like:

______________________________________...
file.txt:123
______________________________________...

could commits look like:

******************************************************...
******************************************************...
commit 123abc...
author: Donald Knuth
Commit Title
* commit
* description
******************************************************...
******************************************************...
______________________________________...
file.txt:123
______________________________________...
file.txt diffs




______________________________________...
file2.txt:123
______________________________________...
file2.txt diffs



******************************************************...
******************************************************...
commit 123abd...
author: Genghis Khan
Commit Title
* commit
* description
******************************************************...
******************************************************...
______________________________________...
file.txt:123
______________________________________...
file.txt diffs




______________________________________...
file2.txt:123
______________________________________...
file2.txt diffs




The rationale behind it is: file diffs and part of a commit. Hence the graphical representation of a commit should be "larger" than the one for each file. Similarly to how "Title1" is often displayed in a larger font than "Title2", in docs for example.

Cheers.

@ericbn
Copy link
Contributor

ericbn commented May 8, 2021

I have a suggestion for this in #398

@Svalorzen
Copy link

Svalorzen commented Oct 18, 2024

Hello, I have just updated #398 with a new PR #497, which rebases the original one to the current next so that it can be merged without conflicts. I have tested it on my machine and it seems to still work well.

I think it would be a shame to let all the work done by @ericbn go to waste, so I'm writing hoping that the PR can be merged as it seems to be a really useful addition when examining lists of commits.

Perhaps @scottchiefbaker could look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants