Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite fails in MinGW / Git Bash on windows #408

Open
paulirish opened this issue May 18, 2021 · 0 comments
Open

test suite fails in MinGW / Git Bash on windows #408

paulirish opened this issue May 18, 2021 · 0 comments

Comments

@paulirish
Copy link
Member

I mentioned this in #407

It turns out these failures exist on master branch too. We've been avoiding them cuz appveyor uses cygwin (which seems pretty uncommon these days IMO)

There are no problems using WSL.

But git bash aka MinGW, which is the bash environment for github windows environment, has a few failures. You can see them here: https://github.com/so-fancy/diff-so-fancy/pull/407/checks?check_run_id=2615100841

Disclaimer: I personally don't care about these being fixed. IMO it's reasonable to expect all dsf windows users to be on WSL and that's it. But.. sharing since I looked into it a bit.

Here's a bit more detail..


not ok 3 Vanilla diff with add/remove empty lines (#366)

looks like there's no block outputted at all.

addremoveemptylines

not ok 17 Empty file add and not ok 18 Empty file delete

not sure, but the assertions about line 5 are found on line 7 here. why? dunno.

but maybe this explains?

emptyfiledelete

not ok 33 Hunk formatting: @@ -1,6 +1,6 @@

hunformatting

easy to see. something really weird with the :3 @ckage.json output…

not ok 37 non-git diff parsing

weird

:8355 @anual.xml.head . same thing as the hunk formatting, looks like.


anyway that's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant