You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disclaimer: I personally don't care about these being fixed. IMO it's reasonable to expect all dsf windows users to be on WSL and that's it. But.. sharing since I looked into it a bit.
Here's a bit more detail..
not ok 3 Vanilla diff with add/remove empty lines (#366)
looks like there's no block outputted at all.
not ok 17 Empty file add and not ok 18 Empty file delete
not sure, but the assertions about line 5 are found on line 7 here. why? dunno.
but maybe this explains?
not ok 33 Hunk formatting: @@ -1,6 +1,6 @@
easy to see. something really weird with the :3 @ckage.json output…
not ok 37 non-git diff parsing
:8355 @anual.xml.head . same thing as the hunk formatting, looks like.
anyway that's it.
The text was updated successfully, but these errors were encountered:
I mentioned this in #407
It turns out these failures exist on
master
branch too. We've been avoiding them cuz appveyor uses cygwin (which seems pretty uncommon these days IMO)There are no problems using WSL.
But git bash aka MinGW, which is the
bash
environment for github windows environment, has a few failures. You can see them here: https://github.com/so-fancy/diff-so-fancy/pull/407/checks?check_run_id=2615100841Disclaimer: I personally don't care about these being fixed. IMO it's reasonable to expect all dsf windows users to be on WSL and that's it. But.. sharing since I looked into it a bit.
Here's a bit more detail..
not ok 3 Vanilla diff with add/remove empty lines (#366)
looks like there's no block outputted at all.
not ok 17 Empty file add
andnot ok 18 Empty file delete
not sure, but the assertions about line 5 are found on line 7 here. why? dunno.
but maybe this explains?
not ok 33 Hunk formatting: @@ -1,6 +1,6 @@
easy to see. something really weird with the
:3 @ckage.json
output…not ok 37 non-git diff parsing
:8355 @anual.xml.head
. same thing as the hunk formatting, looks like.anyway that's it.
The text was updated successfully, but these errors were encountered: