Skip to content

Commit 319f2e2

Browse files
fix: check the type of the initial packet
Before this fix, the client could mark the polling transport as open even though the handshake packet was not received properly (for example, after a parsing error). See also: socketio/engine.io-client@1c8cba8 Backported from 2b5dfb9
1 parent b1b7002 commit 319f2e2

File tree

1 file changed

+1
-1
lines changed
  • src/main/java/io/socket/engineio/client/transports

1 file changed

+1
-1
lines changed

src/main/java/io/socket/engineio/client/transports/Polling.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ private void _onData(Object data) {
115115
Parser.DecodePayloadCallback callback = new Parser.DecodePayloadCallback() {
116116
@Override
117117
public boolean call(Packet packet, int index, int total) {
118-
if (self.readyState == ReadyState.OPENING) {
118+
if (self.readyState == ReadyState.OPENING && Packet.OPEN.equals(packet.type)) {
119119
self.onOpen();
120120
}
121121

0 commit comments

Comments
 (0)