Skip to content

missing dist directory after npm install #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsilvasc opened this issue Dec 27, 2019 · 2 comments · May be fixed by #15
Open

missing dist directory after npm install #12

dsilvasc opened this issue Dec 27, 2019 · 2 comments · May be fixed by #15

Comments

@dsilvasc
Copy link

🐛 Bug description

After installing this package with npm, the node_modules/serverless-localhost/ directory contains just package.json, README.md, LICENSE, and CHANGELOG.md. The dist directory is missing.

Consequently running serverless localhost fails with

Serverless plugin "serverless-localhost" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file.

I think you need to commit the dist directory to the repository per https://stackoverflow.com/questions/46619788/npm-install-from-a-git-repo-leaves-a-pretty-blank-package

🤔 Expected Behavior

The dist directory should be present after installing.

👟 Steps to reproduce

$ npm install softprops/serverless-localhost
$ ls node_modules/serverless-localhost/
CHANGELOG.md  LICENSE       README.md     node_modules/ package.json
$ serverless localhost

  Serverless Error ---------------------------------------

  Serverless plugin "serverless-localhost" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file.

🌍 Your environment

$ npm --version
6.5.0
$ node --version
v11.6.0
$ uname -a
Darwin localhost 18.7.0 Darwin Kernel Version 18.7.0: Sun Dec  1 18:59:03 PST 2019; root:xnu-4903.278.19~1/RELEASE_X86_64 x86_64

serverless version: 1.60.4 (standalone)
serverless-localhost version: latest master, 0.1.0

dsilva added a commit to dsilva/serverless-localhost that referenced this issue Dec 27, 2019
@y2kappa
Copy link

y2kappa commented May 7, 2020

thanks for this, maybe you should submit a PR?

@dsilva
Copy link

dsilva commented May 8, 2020

@y2kappa good point -- submitted #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants