Hide lint behind a feature flag

Author: maciektr

scarb/Cargo.toml

@@ -35,7 +35,7 @@ cairo-lang-starknet.workspace = true
 cairo-lang-syntax.workspace = true
 cairo-lang-test-plugin.workspace = true
 cairo-lang-utils.workspace = true
-cairo-lint-core.workspace = true
+cairo-lint-core = {workspace = true, optional = true }
 camino.workspace = true
 clap.workspace = true
 convert_case.workspace = true
@@ -125,3 +125,7 @@ fs_extra.workspace = true
 scarb-build-metadata = { path = "../utils/scarb-build-metadata" }
 toml.workspace = true
 zip.workspace = true
+
+[features]
+default = ["scarb-lint"]
+scarb-lint = ["dep:cairo-lint-core"]

scarb/src/bin/scarb/commands/lint.rs

@@ -1,18 +1,22 @@
-use scarb::ops::{self, LintOptions};
-
 use crate::args::LintArgs;
 use anyhow::Result;
 use scarb::core::Config;
 
 #[tracing::instrument(skip_all, level = "info")]
 pub fn run(args: LintArgs, config: &Config) -> Result<()> {
+    do_lint(args, config)
+}
+
+#[cfg(feature = "scarb-lint")]
+fn do_lint(args: LintArgs, config: &Config) -> Result<()> {
+    use scarb::ops::{self, LintOptions};
+
     let ws = ops::read_workspace(config.manifest_path(), config)?;
     let packages = args
         .packages_filter
         .match_many(&ws)?
         .into_iter()
         .collect::<Vec<_>>();
-
     ops::lint(
         LintOptions {
             packages,
@@ -23,3 +27,8 @@ pub fn run(args: LintArgs, config: &Config) -> Result<()> {
         &ws,
     )
 }
+
+#[cfg(not(feature = "scarb-lint"))]
+fn do_lint(_args: LintArgs, _config: &Config) -> Result<()> {
+    panic!("scarb was not compiled with the `lint` command enabled")
+}

scarb/src/compiler/db.rs

@@ -20,13 +20,15 @@ use cairo_lang_filesystem::ids::CrateLongId;
 use cairo_lang_semantic::db::PluginSuiteInput;
 use cairo_lang_semantic::plugin::PluginSuite;
 use cairo_lang_utils::ordered_hash_map::OrderedHashMap;
-use cairo_lint_core::plugin::CairoLintAllow;
 use smol_str::SmolStr;
 use std::collections::HashMap;
 use std::path::PathBuf;
 use std::sync::Arc;
 use tracing::trace;
 
+#[cfg(feature = "scarb-lint")]
+use cairo_lint_core::plugin::CairoLintAllow;
+
 pub struct ScarbDatabase {
     pub db: RootDatabase,
     pub proc_macros: Vec<Arc<ProcMacroHostPlugin>>,
@@ -47,10 +49,7 @@ pub(crate) fn build_scarb_root_database(
         proc_macros,
     } = PluginsForComponents::collect(ws, unit)?;
 
-    plugins
-        .get_mut(&unit.main_component().id)
-        .unwrap()
-        .add_analyzer_plugin::<CairoLintAllow>();
+    append_lint_plugin(plugins.get_mut(&unit.main_component().id).unwrap());
 
     let main_component_suite = plugins
         .get_mut(&unit.main_component().id)
@@ -72,6 +71,14 @@ pub(crate) fn build_scarb_root_database(
     Ok(ScarbDatabase { db, proc_macros })
 }
 
+#[cfg(feature = "scarb-lint")]
+fn append_lint_plugin(suite: &mut PluginSuite) {
+    suite.add_analyzer_plugin::<CairoLintAllow>();
+}
+
+#[cfg(not(feature = "scarb-lint"))]
+fn append_lint_plugin(_suite: &mut PluginSuite) {}
+
 /// Sets the plugin suites for crates related to the library components
 /// according to the `plugins_for_components` mapping.
 fn apply_plugins(

scarb/src/ops/mod.rs

@@ -7,7 +7,6 @@ pub use clean::*;
 pub use compile::*;
 pub use expand::*;
 pub use fmt::*;
-pub use lint::*;
 pub use manifest::*;
 pub use metadata::*;
 pub use new::*;
@@ -24,7 +23,6 @@ mod clean;
 mod compile;
 mod expand;
 mod fmt;
-mod lint;
 mod lockfile;
 mod manifest;
 mod metadata;
@@ -36,3 +34,8 @@ mod resolve;
 mod scripts;
 mod subcommands;
 mod workspace;
+
+#[cfg(feature = "scarb-lint")]
+mod lint;
+#[cfg(feature = "scarb-lint")]
+pub use lint::*;

utils/scarb-test-support/Cargo.toml

@@ -15,7 +15,7 @@ dunce.workspace = true
 hyper = "0.14"
 indoc.workspace = true
 itertools.workspace = true
-scarb = { path = "../../scarb" }
+scarb = { path = "../../scarb", default-features = false }
 scarb-build-metadata = { path = "../scarb-build-metadata" }
 scarb-proc-macro-server-types = { path = "../scarb-proc-macro-server-types" }
 scarb-ui = { path = "../scarb-ui" }