Fix cairo-test dep missing warning (#1993)

fixes #1603

Author: maciektr

extensions/scarb-cairo-test/src/main.rs

@@ -66,9 +66,11 @@ fn main() -> Result<()> {
     let metadata = MetadataCommand::new().inherit_stderr().exec()?;
 
     check_scarb_version(&metadata);
-    check_cairo_test_plugin(&metadata);
 
     let matched = args.packages_filter.match_many(&metadata)?;
+    let matched_ids = matched.iter().map(|p| p.id.clone()).collect::<Vec<_>>();
+    check_cairo_test_plugin(&metadata, &matched_ids);
+
     let filter = PackagesFilter::generate_for::<Metadata>(matched.iter());
     let test_kind = args.test_kind.unwrap_or_default();
     let target_names = matched
@@ -214,7 +216,7 @@ fn check_scarb_version(metadata: &Metadata) {
     }
 }
 
-fn check_cairo_test_plugin(metadata: &Metadata) {
+fn check_cairo_test_plugin(metadata: &Metadata, packages: &[PackageId]) {
     let app_version = env!("CARGO_PKG_VERSION").to_string();
     let warn = || {
         println!(
@@ -249,6 +251,9 @@ fn check_cairo_test_plugin(metadata: &Metadata) {
         if cu.target.kind != "test" {
             continue;
         }
+        if !packages.contains(&cu.package) {
+            continue;
+        }
         if !cu
             .cairo_plugins
             .iter()

extensions/scarb-cairo-test/tests/build.rs

@@ -1,7 +1,9 @@
+use assert_fs::prelude::PathChild;
 use assert_fs::TempDir;
 use indoc::{formatdoc, indoc};
 use scarb_test_support::command::Scarb;
 use scarb_test_support::project_builder::ProjectBuilder;
+use scarb_test_support::workspace_builder::WorkspaceBuilder;
 
 #[test]
 fn can_test_without_gas() {
@@ -289,6 +291,37 @@ fn warn_if_cairo_test_plugin_missing() {
        "#});
 }
 
+#[test]
+fn do_not_warn_on_non_tested_package() {
+    let t = TempDir::new().unwrap();
+    let pkg1 = t.child("first");
+    ProjectBuilder::start().name("first").build(&pkg1);
+    let pkg2 = t.child("second");
+    ProjectBuilder::start()
+        .name("second")
+        .dep_cairo_test()
+        .build(&pkg2);
+    WorkspaceBuilder::start()
+        .add_member("first")
+        .add_member("second")
+        .build(&t);
+    Scarb::quick_snapbox()
+        .arg("cairo-test")
+        .arg("--package")
+        .arg("second")
+        .current_dir(&t)
+        .assert()
+        .success()
+        .stdout_matches(indoc! {r#"
+            [..]Compiling test(second_unittest) second v1.0.0 ([..]Scarb.toml)
+            [..]Finished `dev` profile target(s) in [..]
+            testing second ...
+            running 0 tests
+            test result: ok. 0 passed; 0 failed; 0 ignored; 0 filtered out;
+            
+        "#});
+}
+
 #[test]
 fn can_choose_test_kind_to_run() {
     let t = TempDir::new().unwrap();