Rename open_rw->create_rw (#1573)

Follow-up to #1571 

Reasoning outlined in this
[discussion](#1571 (comment))

Author: DelevoXDG

scarb/src/compiler/helpers.rs

@@ -109,7 +109,7 @@ pub fn write_json(
     ws: &Workspace<'_>,
     value: impl Serialize,
 ) -> Result<()> {
-    let file = target_dir.open_rw(file_name, description, ws.config())?;
+    let file = target_dir.create_rw(file_name, description, ws.config())?;
     let file = BufWriter::new(&*file);
     serde_json::to_writer(file, &value)
         .with_context(|| format!("failed to serialize {file_name}"))?;
@@ -123,7 +123,7 @@ pub fn write_string(
     ws: &Workspace<'_>,
     value: impl ToString,
 ) -> Result<()> {
-    let mut file = target_dir.open_rw(file_name, description, ws.config())?;
+    let mut file = target_dir.create_rw(file_name, description, ws.config())?;
     file.write_all(value.to_string().as_bytes())?;
     Ok(())
 }

scarb/src/core/registry/client/cache.rs

@@ -154,7 +154,7 @@ impl<'c> RegistryClientCache<'c> {
             let dl_fs = self.dl_fs.clone();
             move |config: &Config| {
                 let tarball_name = package.tarball_name();
-                dl_fs.open_rw(&tarball_name, &tarball_name, config)
+                dl_fs.create_rw(&tarball_name, &tarball_name, config)
             }
         });
 

scarb/src/core/registry/client/http.rs

@@ -304,7 +304,7 @@ impl<'c> IndexConfigManager<'c> {
     async fn save_in_cache(&self, index_config: &IndexConfig) -> Result<()> {
         let mut file = self
             .cache_fs
-            .open_rw(&self.cache_file_name, &self.cache_file_name, self.config)?
+            .create_rw(&self.cache_file_name, &self.cache_file_name, self.config)?
             .into_async();
         let json = serde_json::to_vec(index_config)?;
         file.write_all(&json).await?;

scarb/src/flock.rs

@@ -164,7 +164,7 @@ impl<'f> AdvisoryLock<'f> {
         let file_lock_arc = match slot.upgrade() {
             Some(arc) => arc,
             None => {
-                let arc = Arc::new(self.filesystem.open_rw(
+                let arc = Arc::new(self.filesystem.create_rw(
                     &self.path,
                     &self.description,
                     self.config,
@@ -249,7 +249,7 @@ impl Filesystem {
     ///
     /// The returned file can be accessed to look at the path and also has read/write access to
     /// the underlying file.
-    pub fn open_rw(
+    pub fn create_rw(
         &self,
         path: impl AsRef<Utf8Path>,
         description: &str,

scarb/src/ops/package.rs

@@ -163,7 +163,7 @@ fn package_one_impl(
     let target_dir = ws.target_dir().child("package");
 
     let mut dst =
-        target_dir.open_rw(format!(".{filename}"), "package scratch space", ws.config())?;
+        target_dir.create_rw(format!(".{filename}"), "package scratch space", ws.config())?;
 
     dst.set_len(0)
         .with_context(|| format!("failed to truncate: {filename}"))?;

scarb/tests/flock.rs

@@ -25,11 +25,10 @@ fn locking_build_artifacts() {
 
     thread::scope(|s| {
         let ws = scarb::ops::read_workspace(config.manifest_path(), &config).unwrap();
-        let lock = ws.target_dir().child(config.profile().to_string()).open_rw(
-            "hello.sierra.json",
-            "artifact",
-            &config,
-        );
+        let lock = ws
+            .target_dir()
+            .child(config.profile().to_string())
+            .create_rw("hello.sierra.json", "artifact", &config);
         let barrier = Arc::new(Barrier::new(2));
 
         s.spawn({