Deduplicate external contracts by full path

Author: maciektr

scarb/src/compiler/compilers/starknet_contract/compiler.rs

@@ -332,9 +332,18 @@ pub fn find_project_contracts(
         Vec::new()
     };
 
-    Ok(internal_contracts
+    // Deduplicate found contracts by contract path.
+    let mut contracts_found = internal_contracts
         .into_iter()
         .chain(external_contracts)
+        .map(|decl| (decl.module_id().full_path(db.upcast()), decl))
+        .sorted_by_key(|(path, _)| path.clone())
+        .collect_vec();
+    contracts_found.dedup_by_key(|(path, _)| path.clone());
+
+    Ok(contracts_found
+        .into_iter()
+        .map(|(_path, decl)| decl)
         .collect())
 }
 

scarb/tests/build_starknet_external_contracts.rs

@@ -572,7 +572,11 @@ fn can_dedup_contract_reexports() {
             [[target.starknet-contract]]
         "#})
         .dep_starknet()
-        .lib_cairo("pub mod a; pub use a::Balance;")
+        .lib_cairo(indoc! {r#"
+            // Note that Balance contract can be accessed both through mod tree and the reexport.
+            pub mod a; 
+            pub use a::Balance;
+        "#})
         .src("src/a.cairo", BALANCE_CONTRACT)
         .build(&hello);