Fix new - abs path warning

Author: maciektr

scarb/src/ops/new.rs

@@ -1,3 +1,4 @@
+use crate::internal::fsx::PathBufUtf8Ext;
 use anyhow::{bail, ensure, Context, Result};
 use camino::{Utf8Path, Utf8PathBuf};
 use indoc::{formatdoc, indoc};
@@ -100,11 +101,17 @@ fn mk(
     // Create project directory in case we are called from `new` op.
     fsx::create_dir_all(&path)?;
 
-    init_vcs(&path, version_control)?;
-    write_vcs_ignore(&path, config, version_control)?;
+    let canonical_path = if let Ok(canonicalize_path) = fsx::canonicalize(&path) {
+        canonicalize_path.try_into_utf8()?
+    } else {
+        path
+    };
+
+    init_vcs(&canonical_path, version_control)?;
+    write_vcs_ignore(&canonical_path, config, version_control)?;
 
     // Create the `Scarb.toml` file.
-    let manifest_path = path.join(MANIFEST_FILE_NAME);
+    let manifest_path = canonical_path.join(MANIFEST_FILE_NAME);
     fsx::write(
         &manifest_path,
         formatdoc! {r#"
@@ -121,7 +128,7 @@ fn mk(
 
     // Create hello world source files (with respective parent directories) if source directory
     // does not exist.
-    let source_dir = path.join(DEFAULT_SOURCE_DIR_NAME);
+    let source_dir = canonical_path.join(DEFAULT_SOURCE_DIR_NAME);
     if !source_dir.exists() {
         fsx::create_dir_all(&source_dir)?;
 

scarb/tests/e2e/new_and_init.rs

@@ -3,6 +3,7 @@ use std::fs;
 use assert_fs::prelude::*;
 use indoc::indoc;
 use predicates::prelude::*;
+use toml::{Table, Value};
 
 use scarb::core::TomlManifest;
 
@@ -146,6 +147,34 @@ fn new_existing() {
         "#});
 }
 
+#[test]
+fn issue_148() {
+    let pt = assert_fs::TempDir::new().unwrap();
+
+    let output = Scarb::quick_snapbox()
+        .arg("--json")
+        .arg("new")
+        .arg("hello")
+        .current_dir(&pt)
+        .output()
+        .expect("Failed to spawn command");
+
+    if !output.stdout.is_empty() {
+        let parsed: Table = serde_json::de::from_slice(&output.stdout).unwrap();
+
+        for (_, value) in parsed {
+            if let Value::String(s) = value {
+                assert!(!s.contains(
+                "compiling this new package may not work due to invalid workspace configuration"
+            ));
+            }
+        }
+    }
+
+    let t = pt.child("hello");
+    assert!(t.is_dir());
+}
+
 #[test]
 fn invalid_package_name() {
     let pt = assert_fs::TempDir::new().unwrap();