Do not enable cfg(test) in main package for integration tests (#1334)

Author: maciektr

scarb/src/ops/resolve.rs

@@ -258,6 +258,16 @@ fn cairo_compilation_unit_for_target(
     let cairo_plugins = solution.cairo_plugins.as_ref().unwrap();
 
     let cfg_set = build_cfg_set(&member_target);
+    let no_test_cfg_set = cfg_set
+        .iter()
+        .filter(|cfg| **cfg != Cfg::name("test"))
+        .cloned()
+        .collect();
+    let no_test_cfg_set = if no_test_cfg_set != cfg_set {
+        Some(no_test_cfg_set)
+    } else {
+        None
+    };
 
     let props: TestTargetProps = member_target.props()?;
     let is_integration_test = props.test_type == TestTargetType::Integration;
@@ -304,17 +314,7 @@ fn cairo_compilation_unit_for_target(
                         enabled_features,
                     )?
                 } else {
-                    let component_cfg_set = cfg_set
-                        .iter()
-                        .filter(|cfg| **cfg != Cfg::name("test"))
-                        .cloned()
-                        .collect();
-
-                    if component_cfg_set != cfg_set {
-                        Some(component_cfg_set)
-                    } else {
-                        None
-                    }
+                    no_test_cfg_set.clone()
                 }
             };
 
@@ -341,7 +341,7 @@ fn cairo_compilation_unit_for_target(
         components.push(CompilationUnitComponent::try_new(
             member.clone(),
             vec![target],
-            None,
+            no_test_cfg_set,
         )?);
 
         // Set test package as main package for this compilation unit.

scarb/tests/build_targets.rs

@@ -360,6 +360,53 @@ fn compile_test_target() {
     assert_eq!(tests.len(), 0);
 }
 
+#[test]
+fn integration_tests_do_not_enable_cfg_in_main_package() {
+    let t = TempDir::new().unwrap();
+    ProjectBuilder::start()
+        .name("hello")
+        .lib_cairo(indoc! {r#"
+            #[cfg(test)]
+            fn f() -> felt252 { 42 }
+        "#})
+        .build(&t);
+    t.child("tests").create_dir_all().unwrap();
+    t.child("tests/test1.cairo")
+        .write_str(indoc! {r#"
+        #[cfg(test)]
+        mod tests {
+            use hello::f;
+            #[test]
+            fn it_works() {
+                assert(f() == 42, 'it works!');
+            }
+        }
+         "#})
+        .unwrap();
+
+    Scarb::quick_snapbox()
+        .arg("build")
+        .arg("--test")
+        .current_dir(&t)
+        .assert()
+        .failure()
+        .stdout_matches(indoc! {r#"
+            [..]Compiling test(hello_unittest) hello v1.0.0 ([..]Scarb.toml)
+            [..]Compiling test(hello_integrationtest) hello_integrationtest v1.0.0 ([..]Scarb.toml)
+            error: Identifier not found.
+             --> [..]test1.cairo:3:16
+                use hello::f;
+                           ^
+
+            error: Type annotations needed. Failed to infer ?0.
+             --> [..]test1.cairo:6:16
+                    assert(f() == 42, 'it works!');
+                           ^*******^
+
+            error: could not compile `hello_integrationtest` due to previous error
+        "#});
+}
+
 #[test]
 fn detect_single_file_test_targets() {
     let t = TempDir::new().unwrap();