Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support caching in projects with different lockfiles location #25

Closed
maciektr opened this issue Aug 13, 2024 · 0 comments · Fixed by #27
Closed

Support caching in projects with different lockfiles location #25

maciektr opened this issue Aug 13, 2024 · 0 comments · Fixed by #27
Assignees
@DelevoXDG

Comments

@maciektr
Copy link
Contributor

Problem

As of now, we only only support caching of project dependencies when Scarb.lock file is localized in the top-level directory of users repo.

setup-scarb/lib/cache-utils.js

Line 71 in 202cd8c

const lockfilePath = path.join(process.env.GITHUB_WORKSPACE, "Scarb.lock");

Proposed Solution

No response

Notes

No response
@mkaput mkaput added this to Scarb Aug 13, 2024
@github-project-automation github-project-automation bot moved this to Triage in Scarb Aug 13, 2024
@maciektr maciektr moved this from Triage to Todo in Scarb Oct 3, 2024
@DelevoXDG DelevoXDG mentioned this issue Oct 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
@DelevoXDG
Support specifying custom Scarb.lock path (#27)
f4e6c94 
- Allow specifying path to `Scarb.lock` via optional `scarb-lock`
argument
- If not specified, default to `Scarb.lock` in cwd for consistency with
`toolVersionsPath`
- Fix caching test steps

Closes #25
@github-project-automation github-project-automation bot moved this from Todo to Done in Scarb Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DelevoXDG DelevoXDG

Labels
None yet
Projects
Scarb
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support specifying custom Scarb.lock path software-mansion/setup-scarb
2 participants
@maciektr @DelevoXDG