clean up fallback and receive tests

Author: ItsNickBarry

spec/proxy/Proxy.behavior.ts

@@ -39,7 +39,17 @@ export function describeBehaviorOfProxy(
     });
 
     describe('receive()', () => {
-      it('forwards value to implementation');
+      it('forwards value to implementation via delegatecall', async () => {
+        // TODO: receive tests pass because hardhat-exposed functions used as implementations are payable
+        const [signer] = await ethers.getSigners();
+
+        await expect(
+          signer.sendTransaction({
+            to: await instance.getAddress(),
+            value: 1n,
+          }),
+        ).not.to.be.reverted;
+      });
     });
   });
 }

spec/proxy/diamond/DiamondProxy.behavior.ts

@@ -1,5 +1,5 @@
 import { describeFilter } from '@solidstate/library';
-import { ProxyBehaviorArgs } from '@solidstate/spec';
+import { describeBehaviorOfProxy, ProxyBehaviorArgs } from '@solidstate/spec';
 import { IDiamondProxy } from '@solidstate/typechain-types';
 import { expect } from 'chai';
 import { ethers } from 'hardhat';
@@ -20,6 +20,8 @@ export function describeBehaviorOfDiamondProxy(
       instance = await deploy();
     });
 
+    describeBehaviorOfProxy(deploy, args, skips);
+
     describe('fallback()', () => {
       it('forwards data with matching selector call to facet', async () => {
         expect(instance.interface.hasFunction(args.implementationFunction)).to

spec/proxy/diamond/fallback/DiamondProxyFallback.behavior.ts

@@ -31,14 +31,36 @@ export function describeBehaviorOfDiamondProxyFallback(
       nonOwner = await args.getNonOwner();
     });
 
-    describeBehaviorOfDiamondProxy(async () => instance, args, skips);
+    describeBehaviorOfDiamondProxy(async () => instance, args, [
+      'receive()',
+      ...(skips ?? []),
+    ]);
 
     describe('fallback()', () => {
-      it('forwards data without matching selector to fallback contract');
+      it('forwards data without matching selector to fallback contract', async () => {
+        await expect(
+          owner.sendTransaction({
+            to: await instance.getAddress(),
+          }),
+        ).to.be.revertedWithCustomError(
+          instance,
+          'Proxy__ImplementationIsNotContract',
+        );
+      });
     });
 
     describe('receive()', () => {
-      it('forwards value to fallback contract');
+      it('forwards value to fallback contract', async () => {
+        await expect(
+          owner.sendTransaction({
+            to: await instance.getAddress(),
+            value: 1n,
+          }),
+        ).to.be.revertedWithCustomError(
+          instance,
+          'Proxy__ImplementationIsNotContract',
+        );
+      });
     });
 
     describe('#getFallbackAddress()', () => {

test/proxy/diamond/SolidstateDiamondProxy.ts

@@ -54,6 +54,6 @@ describe('SolidstateDiamondProxy', () => {
       fallbackAddress: ethers.ZeroAddress,
       immutableSelectors,
     },
-    ['fallback()'],
+    ['fallback()', 'receive()'],
   );
 });