Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Interface shadow #56

Closed
julesGoullee opened this issue Nov 25, 2021 · 3 comments
Closed

Supports Interface shadow #56

julesGoullee opened this issue Nov 25, 2021 · 3 comments

Comments

@julesGoullee
Copy link
Contributor

When deploying with hardhat-deploy build in diamond, erc165 clash with the diamantaire also implementing erc165.
As supportedInferface needs to be added to diamondStorage array, the need for the erc165 interface into the solidstate contract enter into conflict.

@julesGoullee julesGoullee changed the title supportsInterface shadow Supports Interface shadow Nov 25, 2021
@ItsNickBarry
Copy link
Member

Did the discussion the the EIP-2535 Discord resolve your issue?

The hardhat-deploy plugin uses one of the reference diamond implementations, but those are not explicitly supported by SolidState. The reason is that some of their design elements, while suitable for a reference implementation, cause inconsistencies when used within the context of the larger development ecosystem. Therefore, it is possible to use SolidState in combination with the reference implementations, but some overrides may be necessary.

@julesGoullee
Copy link
Contributor Author

I understand a bit more the issue now yes. From dev point of view will be great to have consistency across the ecosystem tools, I will raise this issue on hardhat side as well

@ItsNickBarry
Copy link
Member

Part of the problem here is that diamondCut is complicated. I hope to address this in the future with some utility functions. Not yet sure what the implementation will look like, will track in #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants