Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance and ERC20Votes Integration #84

Open
decafboba opened this issue Mar 22, 2022 · 1 comment
Open

Governance and ERC20Votes Integration #84

decafboba opened this issue Mar 22, 2022 · 1 comment

Comments

@decafboba
Copy link

I think it would be a great goal to try to match OZ's governance contracts in this pattern, as some kind of governance is super important for the management of systems using diamonds.

I also noticed that some of the current ERC20 functionality has the ability for snapshots, which I believe is similar to what ERC20Votes needs to function.

Ideally sticking with as much of the same logic as OpenZepplin seems ideal, as their code is well audited and they have developed good standards.

@ItsNickBarry
Copy link
Member

Some work has begun on this, predating even the OZ governance release. We need to decide whether it makes sense to build on top of that old branch, or to start fresh. Don't have the capacity for this in the immediate future, but hopefully soon. A PR would be considered, in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants