-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing Paperclip adapter #5033
Comments
It could cost many applications a lot of dev time to switch the adapter and QA everything. I think it would be best to place it in a separate gem and archive it. Then recommend applications begin using ActiveStorage and make the switch when possible. |
I'm experimenting with trying to build a generator that installs the adapter in the host application so that we don't have to create an extension. If a user still uses the Paperclip adapter, we can print a deprecation message asking to run the generator to install the adapter. From that moment, they can keep using the adapter, but they will be responsible for maintaining it. I can push some code soon to show better what I mean, but if you have preliminary feedback on the approach, let me know! |
@waiting-for-dev @BenMorganIO I opened a PR with the approach proposed, let me know your thoughts! It's not urgent so take your time. |
We're not supporting Rails v5.2 anymore, so all stores using Solidus can use the newer ActiveStorage adapter. However, we might first want to hear about the experience of stores using it. One option can be extracting it to a separate gem and archive it.
The text was updated successfully, but these errors were encountered: