Skip to content

Commit 9424ac1

Browse files
committed
feat: enable MODMESH_USE_PYSIDE to on, by default
refactor: remove the switch refactor: comments refactor: update the comment for the PySide6 Change the comment line and remove msg
1 parent f55469c commit 9424ac1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,8 @@ set(MODMESH_INCLUDE_DIR "${CMAKE_CURRENT_LIST_DIR}/cpp" CACHE INTERNAL "")
138138

139139
include_directories(${MODMESH_INCLUDE_DIR})
140140

141+
# PySide6 is required since 2023 (see issue https://github.com/solvcon/modmesh/issues/220)
142+
add_compile_definitions(MODMESH_USE_PYSIDE)
141143
execute_process(
142144
COMMAND python3 -c "import sys, os, PySide6; sys.stdout.write(os.path.dirname(PySide6.__file__))"
143145
OUTPUT_VARIABLE PYSIDE6_PYTHON_PACKAGE_PATH

cpp/modmesh/pilot/wrap_pilot.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#include <QClipboard>
3737
#include <QMenu>
3838

39-
// Usually MODMESH_PYSIDE6_FULL is not defined unless for debugging.
39+
// PySide6 is required since 2023 (see issue https://github.com/solvcon/modmesh/issues/220)
4040
#ifdef MODMESH_PYSIDE6_FULL
4141
#include <pyside.h>
4242
#else // MODMESH_PYSIDE6_FULL

0 commit comments

Comments
 (0)