Skip to content

Commit 6b35854

Browse files
committed
Remove unnecessary rootReducer creator
1 parent 323de07 commit 6b35854

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

src/commons/application/reducers/RootReducer.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,20 @@ import { StoriesReducer as stories } from '../../../features/stories/StoriesRedu
77
import { FileSystemReducer as fileSystem } from '../../fileSystem/FileSystemReducer';
88
import { SideContentReducer as sideContent } from '../../sideContent/SideContentReducer';
99
import { WorkspaceReducer as workspaces } from '../../workspace/WorkspaceReducer';
10+
import { OverallState } from '../ApplicationTypes';
1011
import { RouterReducer as router } from './CommonsReducer';
1112
import { SessionsReducer as session } from './SessionsReducer';
1213

13-
const createRootReducer = () =>
14-
combineReducers({
15-
router,
16-
achievement,
17-
dashboard,
18-
playground,
19-
session,
20-
stories,
21-
workspaces,
22-
fileSystem,
23-
sideContent
24-
});
14+
const rootReducer = combineReducers<OverallState>({
15+
router,
16+
achievement,
17+
dashboard,
18+
playground,
19+
session,
20+
stories,
21+
workspaces,
22+
fileSystem,
23+
sideContent
24+
});
2525

26-
export default createRootReducer;
26+
export default rootReducer;

src/pages/createStore.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import createSagaMiddleware from 'redux-saga';
55
import { SourceActionType } from 'src/commons/utils/ActionsHelper';
66

77
import { defaultState, OverallState } from '../commons/application/ApplicationTypes';
8-
import createRootReducer from '../commons/application/reducers/RootReducer';
8+
import rootReducer from '../commons/application/reducers/RootReducer';
99
import MainSaga from '../commons/sagas/MainSaga';
1010
import { generateOctokitInstance } from '../commons/utils/GitHubPersistenceHelper';
1111
import { loadStoredState, SavedState, saveState } from './localStorage';
@@ -21,7 +21,7 @@ export function createStore() {
2121
const initialStore = loadStore(loadStoredState()) || defaultState;
2222

2323
const createdStore = configureStore<OverallState, SourceActionType>({
24-
reducer: createRootReducer(),
24+
reducer: rootReducer,
2525
// Fix for redux-saga type incompatibility
2626
// See: https://github.com/reduxjs/redux-toolkit/issues/3950
2727
middleware: middleware as any,

0 commit comments

Comments
 (0)