Fix path normalize check for Windows (#350)

bulldy80 · web-flow · commit a57b018786a3 · 2024-06-05T15:32:13.000+02:00
`path.normalize` on Windows returns paths with back-slashes (\) instead of forward -slashes (/), which causes the check here to fail.

This change fixes the issue by replacing all the back-slashes with forward-slashes.
diff --git a/src/Packages.ts b/src/Packages.ts
@@ -8,7 +8,7 @@ export class Packages {
   constructor(public readonly projectRoot: string) {}
   private cache: Map<string, ScipSymbol> = new Map()
   public symbol(filePath: string): ScipSymbol {
-    if (path.normalize(filePath) !== filePath) {
+    if (path.normalize(filePath).replaceAll('\\', '/') !== filePath) {
       throw new Error(
         `unexpected error: path.normalize('${filePath}') !== ${filePath}`
       )

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ export class Packages {`
`8`	`8`	`constructor(public readonly projectRoot: string) {}`
`9`	`9`	`private cache: Map<string, ScipSymbol> = new Map()`
`10`	`10`	`public symbol(filePath: string): ScipSymbol {`
`11`		`- if (path.normalize(filePath) !== filePath) {`
	`11`	`+ if (path.normalize(filePath).replaceAll('\\', '/') !== filePath) {`
`12`	`12`	`throw new Error(`
`13`	`13`	`unexpected error: path.normalize('${filePath}') !== ${filePath}`
`14`	`14`	`)`