Fix module for puppet 6 support #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 Thanks for fixing it. |
mwhahaha
force-pushed
the
fix-tdagent-provider
branch
from
81a2812 to
f04f72e
Compare
mwhahaha
changed the title
There are three issues for puppet 6 tests. The first is that the tdagent provider definition is incorrect. We don't need to wrap the definition in a parser function as it should just be loaded. The second is that we need to include the fluentd when testing the plugin resource so that the relationship matcher works correctly. The third is that yumrepo has been moved to it's own module and must be defined as a dependency. There is also an issue with the acceptance test because we don't have the required dependencies to build the test plugin. Fixes: soylent#39
mwhahaha
force-pushed
the
fix-tdagent-provider
branch
from
f04f72e to
6924958
Compare
Author
|
looks like td-agent is broken itself, not sure the best way to address it. will look into it if I have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to wrap the definition in a parser function as it should
just be loaded.
Fixes: #39