Tweak Netherlands holidays (#263)

* Tweak Netherlands holidays

* Fix phpstan issue

Author: mbardelmeijer

src/Countries/Netherlands.php

@@ -15,13 +15,12 @@ protected function allHolidays(int $year): array
     {
         return array_merge([
             'Nieuwjaarsdag' => '01-01',
-            'Bevrijdingsdag' => '05-05',
             'Eerste kerstdag' => '12-25',
             'Tweede kerstdag' => '12-26',
         ], $this->variableHolidays($year));
     }
 
-    /** @return array<string, CarbonImmutable> */
+    /** @return array<string, string|CarbonImmutable> */
     protected function variableHolidays(int $year): array
     {
         $koningsDag = CarbonImmutable::createFromDate($year, 4, 27);
@@ -32,14 +31,19 @@ protected function variableHolidays(int $year): array
 
         $easter = $this->easter($year);
 
-        return [
+        $holidays = [
             'Koningsdag' => $koningsDag,
-            'Goede Vrijdag' => $easter->subDays(2),
             'Eerste paasdag' => $easter,
             'Tweede paasdag' => $easter->addDay(),
             'Hemelvaartsdag' => $easter->addDays(39),
             'Eerste pinksterdag' => $easter->addDays(49),
             'Tweede pinksterdag' => $easter->addDays(50),
         ];
+
+        if ($year % 5 === 0) {
+            $holidays['Bevrijdingsdag'] = '05-05';
+        }
+
+        return $holidays;
     }
 }

src/Countries/Spain.php

@@ -394,6 +394,7 @@ protected function regionHolidays2024(): array
         };
     }
 
+    /** @return array<string, string> */
     protected function regionHolidays2025(): array
     {
         $sanJose = ['San José' => '03-19'];

tests/.pest/snapshots/Countries/NetherlandsTest/it_can_calculate_dutch_holidays.snap

@@ -3,10 +3,6 @@
         "name": "Nieuwjaarsdag",
         "date": "2024-01-01"
     },
-    {
-        "name": "Goede Vrijdag",
-        "date": "2024-03-29"
-    },
     {
         "name": "Eerste paasdag",
         "date": "2024-03-31"
@@ -19,10 +15,6 @@
         "name": "Koningsdag",
         "date": "2024-04-27"
     },
-    {
-        "name": "Bevrijdingsdag",
-        "date": "2024-05-05"
-    },
     {
         "name": "Hemelvaartsdag",
         "date": "2024-05-09"

tests/.pest/snapshots/Countries/NetherlandsTest/it_can_calculate_dutch_holidays_with_bevrijdingsdag_every_5_year.snap

@@ -0,0 +1,42 @@
+[
+    {
+        "name": "Nieuwjaarsdag",
+        "date": "2025-01-01"
+    },
+    {
+        "name": "Eerste paasdag",
+        "date": "2025-04-20"
+    },
+    {
+        "name": "Tweede paasdag",
+        "date": "2025-04-21"
+    },
+    {
+        "name": "Koningsdag",
+        "date": "2025-04-26"
+    },
+    {
+        "name": "Bevrijdingsdag",
+        "date": "2025-05-05"
+    },
+    {
+        "name": "Hemelvaartsdag",
+        "date": "2025-05-29"
+    },
+    {
+        "name": "Eerste pinksterdag",
+        "date": "2025-06-08"
+    },
+    {
+        "name": "Tweede pinksterdag",
+        "date": "2025-06-09"
+    },
+    {
+        "name": "Eerste kerstdag",
+        "date": "2025-12-25"
+    },
+    {
+        "name": "Tweede kerstdag",
+        "date": "2025-12-26"
+    }
+]

tests/Countries/NetherlandsTest.php

@@ -15,5 +15,16 @@
         ->not()->toBeEmpty();
 
     expect(formatDates($holidays))->toMatchSnapshot();
+});
+
+it('can calculate dutch holidays with bevrijdingsdag every 5 year', function () {
+    CarbonImmutable::setTestNow('2025-01-01');
 
+    $holidays = Holidays::for(country: 'nl')->get();
+
+    expect($holidays)
+        ->toBeArray()
+        ->not()->toBeEmpty();
+
+    expect(formatDates($holidays))->toMatchSnapshot();
 });