Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml: too many buttons labelled "Pay". unclear which action is final #9276

Open
SomberNight opened this issue Oct 22, 2024 · 1 comment
Open
Labels

Comments

@SomberNight
Copy link
Member

SomberNight commented Oct 22, 2024

For on-chain payments at least, in the qml gui, I think the flow is unclear regarding which dialog is the "final" dialog: which button is the final button that if you click there is no going back.


Upon entering a bitcoin address, there is this first dialog. What happens if I click "Pay"? Does it send? But wait how do I set the fee, etc?

pic1

pic1


Well, ok, I'll click it. Oh ok, I can tweak settings now. There is a "Pay" button again. What happens if I click it? Does it send?

pic2

pic2


And actually in current releases, whether it sends depends on having a PIN code configured.
Without a PIN code, it signs and broadcasts directly. With a PIN code set, it prompts for it now.

(I've changed that in c90c87a to also show a final confirmation popup for the no-PIN case)

pic3

pic3


I am not sure what would be the best way to change this, but I think it should be clear to the user if pressing a button actually sends the tx. (I mean this in general, so also e.g. for the lightning flow)

Relatedly, the desktop GUI has a button labelled "Pay..." to suggest there will be a follow-up dialog: #6698

@accumulator
Copy link
Member

agreed, noticed this too. I adapted the obvious ones on master, but for consistency we should also replace other non-final actions in dialogs, e.g. 'Open Channel', 'Close Channel' etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants