Skip per-key metric lookups in active_experiments when no metrics exist

Author: andrehjr

lib/split/user.rb

@@ -56,7 +56,7 @@ def cleanup_old_versions!(experiment)
 
     def active_experiments
       experiments_by_key = keys_without_finished(user.keys).each_with_object({}) do |key, memo|
-        memo[key] = Metric.possible_experiments(key_without_version(key))
+        memo[key] = experiments_for(key_without_version(key))
       end
 
       names = experiments_by_key.values.flatten.map(&:name).uniq
@@ -95,5 +95,19 @@ def keys_without_finished(keys)
       def key_without_version(key)
         key.split(/\:\d(?!\:)/)[0]
       end
+
+      def experiments_for(name)
+        if metrics_defined?
+          Metric.possible_experiments(name)
+        else
+          Array(Experiment.find(name))
+        end
+      end
+
+      def metrics_defined?
+        return @metrics_defined if defined?(@metrics_defined)
+        @metrics_defined =
+          Split.configuration.metrics.any? || Split.redis.exists?(:metrics)
+      end
   end
 end

spec/user_spec.rb

@@ -137,6 +137,18 @@
       expect(Split.redis).to receive(:hmget).with(:experiment_winner, any_args).once.and_call_original
       @subject.active_experiments
     end
+
+    it "resolves experiments directly, without per-key metric lookups, when no metrics are defined" do
+      expect(Split::Metric).not_to receive(:possible_experiments)
+      expect(@subject.active_experiments).to eq("active" => "red")
+    end
+
+    it "still honors a metric persisted only in Redis" do
+      Split::Metric.new(name: :conversion, experiments: [Split::ExperimentCatalog.find("active")]).save
+
+      expect(Split::Metric).to receive(:possible_experiments).at_least(:once).and_call_original
+      expect(@subject.active_experiments).to eq("active" => "red")
+    end
   end
 
   context "allows user to be loaded from adapter" do