HYBIM 719 rebrand package metadata#19
Conversation
Result output from speckit implement:
|
…d repository links
b7f3fa1 to
f510437
Compare
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent. It may contain mistakes.
Verdict: approve — Focused, low-risk metadata rebrand; version is consistently synced and the distribution-name change is covered by tests.
Follow-ups
Suggested follow-up work that could be tracked as Shortcut stories:
src/splunk_ao/utils/headers_data.py:68-68: The telemetry SDK header still emits thegalileo-python/prefix. This is intentionally out of scope for HYBIM-719 per the PR description, but a future ticket should rebrand the header prefix (and theX-Galileo-SDKheader name) to the Splunk AO identity if/when downstream consumers are ready.
|
|
||
| [project.urls] | ||
| Repository = "https://github.com/rungalileo/galileo-python" | ||
| Repository = "https://github.com/signalfx/splunk-ao-python" |
There was a problem hiding this comment.
🔵 nit (question): The Repository URL points to the signalfx org, but this repository lives at github.com/splunk/splunk-ao-python. Is signalfx/splunk-ao-python the intended canonical/publish location? If not, this should match the splunk org. (Your speckit verification lists the signalfx URL as expected, so flagging only to confirm it's deliberate.)
There was a problem hiding this comment.
the speckit was built before the repo was moved. I'll update this!
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent. It may contain mistakes.
Verdict: approve — Clean, consistent package-metadata rebrand with correct tests; version lookup and semantic-release config are in sync, and the one open review comment is already resolved.
Summary
HYBIM-719 rebrands the root Agent Observability SDK package metadata from Galileo to the approved Splunk AO package identity.
This PR is built on top of #17 due to the folder/class renames. Changeset will be larger as a result.
Changes include:
splunk-ao2.3.0to0.1.0splunk_ao.__version__synchronized withpyproject.tomlsplunk-aodistributionThe existing
galileo-python/telemetry header prefix is intentionally preserved per HYBIM-719 scope.Scope Notes
This change is limited to root SDK package metadata/versioning and directly affected package-version helper tests.
Not changed:
galileo-a2a/galileo-adkpackage metadatasrc/galileo/resources/