Skip to content

Commit c7b130d

Browse files
authored
fix: 검색 api 버그 수정 (#373)
* fix: 검색 api 버그 수정 * ci: ci/cd 파일 변경 * ci: ci/cd 파일 변경
1 parent e46c766 commit c7b130d

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

.github/workflows/ci_gradle.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
shell: bash
3232

3333
- name: Start Docker Compose
34-
run: docker-compose -f docker-compose-test.yml up -d
34+
run: docker compose up -d
3535

3636
- name: Grant execute permission for gradlew
3737
run: chmod +x gradlew

api/src/main/java/com/sponus/sponusbe/domain/organization/controller/OrganizationController.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public ApiResponse<PageResponse<OrganizationSearchResponse>> searchOrganization(
9393
@AuthOrganization Organization organization
9494
) {
9595
return ApiResponse.onSuccess(
96-
organizationQueryService.searchOrganizations(pageCondition, keyword, organization));
96+
organizationQueryService.searchOrganizationsV2(pageCondition, keyword, organization));
9797
}
9898

9999
@DeleteMapping("/search")

api/src/main/java/com/sponus/sponusbe/domain/organization/service/OrganizationQueryService.java

+10-9
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import org.springframework.stereotype.Service;
1414
import org.springframework.transaction.annotation.Transactional;
1515

16+
import com.sponus.coredomain.domain.bookmark.repository.BookmarkRepository;
1617
import com.sponus.coredomain.domain.organization.Organization;
1718
import com.sponus.coredomain.domain.organization.enums.OrganizationType;
1819
import com.sponus.coredomain.domain.organization.enums.ProfileStatus;
@@ -36,6 +37,7 @@ public class OrganizationQueryService {
3637

3738
private final OrganizationRepository organizationRepository;
3839
private final SearchHistoryRepository searchHistoryRepository;
40+
private final BookmarkRepository bookmarkRepository;
3941

4042
public Boolean verifyName(String name) {
4143
return organizationRepository.existsByName(name);
@@ -46,10 +48,10 @@ public PageResponse<OrganizationGetResponse> getOrganizations(
4648
PageCondition pageCondition,
4749
OrganizationType organizationType) {
4850
// TODO: FETCH JOIN으로 변경
49-
Set<Long> bookmarkedOrganizationIds = authOrganization.getBookmarks()
50-
.stream()
51-
.map(bookmark -> bookmark.getTarget().getId())
51+
Set<Long> bookmarkedOrganizationIds = bookmarkRepository.findByOrganization(authOrganization).stream()
52+
.map((bookmark) -> bookmark.getTarget().getId())
5253
.collect(Collectors.toSet());
54+
5355
Pageable pageable = PageRequest.of(pageCondition.getPage() - 1, pageCondition.getSize());
5456
List<OrganizationGetResponse> organizations = organizationRepository.findOrganizations(
5557
organizationType, pageable, authOrganization.getId())
@@ -66,10 +68,10 @@ public PageResponse<OrganizationGetResponse> getOrganizations(
6668
public PageResponse<OrganizationSearchResponse> searchOrganizations(PageCondition pageCondition, String keyword,
6769
Organization authOrganization) {
6870

69-
Set<Long> bookmarkedOrganizationIds = authOrganization.getBookmarks()
70-
.stream()
71-
.map(bookmark -> bookmark.getTarget().getId())
71+
Set<Long> bookmarkedOrganizationIds = bookmarkRepository.findByOrganization(authOrganization).stream()
72+
.map((bookmark) -> bookmark.getTarget().getId())
7273
.collect(Collectors.toSet());
74+
7375
Pageable pageable = PageRequest.of(pageCondition.getPage() - 1, pageCondition.getSize());
7476

7577
List<OrganizationSearchResponse> organizations = organizationRepository.findByNameContains(
@@ -95,9 +97,8 @@ public PageResponse<OrganizationSearchResponse> searchOrganizationsV2(
9597

9698
Page<Organization> organizations = organizationRepository.searchOrganizationV2(condition, pageable);
9799

98-
Set<Long> bookmarkedOrganizationIds = authOrganization.getBookmarks()
99-
.stream()
100-
.map(bookmark -> bookmark.getTarget().getId())
100+
Set<Long> bookmarkedOrganizationIds = bookmarkRepository.findByOrganization(authOrganization).stream()
101+
.map((bookmark) -> bookmark.getTarget().getId())
101102
.collect(Collectors.toSet());
102103

103104
return PageResponse.of(organizations.map(organization ->

0 commit comments

Comments
 (0)