Skip to content

Fix video frame bug #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix video frame bug #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b33f2
refactor
J4t-P Oct 16, 2025
34eeca5
Add fix video mixer fix
J4t-P Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ios/DualCameraPreview.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,15 @@ import CoreLocation
}

if let sessionManager = self.sessionManager,
sessionManager.isReady() {
sessionManager.isReady() {
sessionManager.stopSession()
sessionManager.videoMixer.unlockOrientation()
}

DispatchQueue.main.async {
NotificationCenter.default.removeObserver(self, name: UIDevice.orientationDidChangeNotification, object: nil)

DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) {
DispatchQueue.main.asyncAfter(deadline: .now()) {
self.previewBuilder?.teardownPreview()
self.sessionManager = nil
self.previewBuilder = nil
Expand Down
1 change: 0 additions & 1 deletion src/ios/VideoMixer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ class VideoMixer {
if let pixelBuffer = pixelBuffer {
pixelBuffers.append(pixelBuffer)
}
pixelBuffer = nil
}
pixelBuffers.removeAll()
}
Expand Down
10 changes: 5 additions & 5 deletions src/ios/VideoRecorder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ class VideoRecorder {
}
}

print("VideoRecorder: Writer initialized at \(self.outputURL!.path)")
writer.startWriting()
self.isWriting = true
self.startTime = nil
self.completionHandler = nil

DispatchQueue.main.async {
Expand All @@ -119,12 +120,11 @@ class VideoRecorder {

guard self.isWriting,
let writer = self.assetWriter,
writer.status == .unknown || writer.status == .writing,
writer.status == .writing,
let vInput = self.videoInput,
let adaptor = self.adaptor else { return }

if writer.status == .unknown {
writer.startWriting()
if self.startTime == nil {
writer.startSession(atSourceTime: presentationTime)
self.startTime = presentationTime
}
Expand Down Expand Up @@ -235,4 +235,4 @@ class VideoRecorder {
_isWriting = newValue
}
}
}
}
Loading