Skip to content

Commit ea35d45

Browse files
committed
Remove unnecessary reflection in RemoteChunkHandlerFactoryBean
Signed-off-by: Stefano Cordio <[email protected]>
1 parent 0164216 commit ea35d45

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/RemoteChunkHandlerFactoryBean.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,12 @@ public ChunkHandler<T> getObject() throws Exception {
122122
stepContributionSource = (StepContributionSource) chunkWriter;
123123
}
124124

125-
Assert.state(step instanceof TaskletStep, "Step [" + step.getName() + "] must be a TaskletStep");
125+
Assert.state(step != null, "A TaskletStep must be provided");
126126
if (logger.isDebugEnabled()) {
127127
logger.debug("Converting TaskletStep with name=" + step.getName());
128128
}
129129

130-
Tasklet tasklet = getTasklet(step);
130+
Tasklet tasklet = step.getTasklet();
131131
Assert.state(tasklet instanceof ChunkOrientedTasklet<?>,
132132
"Tasklet must be ChunkOrientedTasklet in step=" + step.getName());
133133

@@ -227,15 +227,6 @@ private ChunkProcessor<T> getChunkProcessor(ChunkOrientedTasklet<?> tasklet) {
227227
return (ChunkProcessor<T>) getField(tasklet, "chunkProcessor");
228228
}
229229

230-
/**
231-
* Pull a Tasklet out of a step.
232-
* @param step a TaskletStep
233-
* @return the Tasklet
234-
*/
235-
private Tasklet getTasklet(TaskletStep step) {
236-
return (Tasklet) getField(step, "tasklet");
237-
}
238-
239230
private static Object getField(Object target, String name) {
240231
Assert.notNull(target, "Target object must not be null");
241232
Field field = ReflectionUtils.findField(target.getClass(), name);

0 commit comments

Comments
 (0)